Patch flatbuffers to fix a warning that occurs with some compiler versions #1322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a patch to the flatbuffers version that we are pinned to that fixes an unused-variable warning.
Without this, after updating to xcode 14.3 a newer c compiler fails the build due to this warning about flatbuffers source.
In the flatbuffers repo this unused variable is not removed until much later when the relevant code is basically completely rewritten. So pinning to a newer version of flatbuffers can have other side effects. (Including requiring a newer version of cmake)
The content of the cmake/external/flatbuffers file is basically copied from the similar websockets file which also applies a patch.
Testing
Verified that local builds fail without this patch and succeed with this patch.
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.