Skip to content

Patch flatbuffers to fix a warning that occurs with some compiler versions #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2023

Conversation

AlmostMatt
Copy link
Contributor

@AlmostMatt AlmostMatt commented May 12, 2023

Description

Add a patch to the flatbuffers version that we are pinned to that fixes an unused-variable warning.
Without this, after updating to xcode 14.3 a newer c compiler fails the build due to this warning about flatbuffers source.

In the flatbuffers repo this unused variable is not removed until much later when the relevant code is basically completely rewritten. So pinning to a newer version of flatbuffers can have other side effects. (Including requiring a newer version of cmake)

The content of the cmake/external/flatbuffers file is basically copied from the similar websockets file which also applies a patch.


Testing

Verified that local builds fail without this patch and succeed with this patch.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@AlmostMatt AlmostMatt marked this pull request as ready for review May 12, 2023 19:38
@AlmostMatt AlmostMatt requested a review from jonsimantov May 12, 2023 19:41
@AlmostMatt AlmostMatt added skip-release-notes Skip release notes check and removed skip-release-notes Skip release notes check labels May 15, 2023
@AlmostMatt AlmostMatt merged commit a395148 into main May 15, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 15, 2023
@github-actions
Copy link

github-actions bot commented May 15, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @AlmostMatt on commit a395148
Last updated: Mon May 15 14:59 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  TransactionTest.TestCancellationOnError
[TEST] [FLAKINESS] [Android] [2/3 os: ubuntu macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 15, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 15, 2023
@AlmostMatt AlmostMatt deleted the amatt-flatbuffers-patch branch May 19, 2023 21:13
@firebase firebase locked and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants