Skip to content

Add GitHub token to saved credentials to avoid throttling. #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 3, 2021
Merged

Add GitHub token to saved credentials to avoid throttling. #727

merged 25 commits into from
Nov 3, 2021

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Nov 2, 2021 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Various things (cmake, Cocoapods) manually run git to clone repositories from github.com. This PR adds a GitHub token to the saved credentials, which will prevent GitHub from throttling those requests.

This PR also ensures a GITHUB_TOKEN environment variable is present, for CMake to use.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running all 3 affected workflows.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@google-cla google-cla bot added the cla: yes label Nov 2, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Nov 2, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Nov 2, 2021
@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 49e9ede
Last updated: Wed Nov 3 12:16 PDT 2021
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [Android] [windows, macos] [android_target]
storage [TEST] [ERROR] [Android] [macos] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Nov 2, 2021
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Nov 2, 2021
@jonsimantov
Only temporarily modify the repo URL to include the token.
eaf479a 
Otherwise, Cocoapods loses track of which repo this is and attempts to fetch it again when you run pod install.
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Nov 2, 2021
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Nov 2, 2021
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Nov 2, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Nov 2, 2021
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Nov 2, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Nov 2, 2021
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Nov 2, 2021
@jonsimantov jonsimantov requested a review from a-maurice November 2, 2021 20:41
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Nov 2, 2021
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Nov 2, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Nov 3, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Nov 3, 2021
@jonsimantov jonsimantov changed the title Add GitHub token to Cocoapods Github URL to avoid throttling. Add GitHub token to saved credentials to avoid throttling. Nov 3, 2021
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Nov 3, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 3, 2021
@jonsimantov jonsimantov requested a review from a-maurice November 3, 2021 17:07
@jonsimantov
Copy link
Contributor Author

@a-maurice I found a much simpler way to do this that will work for all git requests, PTAL.

@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label Nov 3, 2021
@jonsimantov jonsimantov merged commit 49e9ede into main Nov 3, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Nov 3, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 3, 2021
@firebase firebase locked and limited conversation to collaborators Dec 4, 2021
@jonsimantov jonsimantov deleted the feature/add-token-to-pod-repo branch December 22, 2021 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice Awaiting requested review from a-maurice

Assignees
No one assigned
Labels
cla: yes skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice