Skip to content

Merge main into the AdMob Feature Branch #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/cpp-packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,8 @@ jobs:
run: |
cd out-sdk
find .. -type f -print > src_file_list.txt
# Remove intermediate build files (.o and .obj) files to save space.
find . -type f -name '*.o' -or -name '*.obj' -print0 | xargs -0 rm -f --
tar -czhf ../firebase-cpp-sdk-${{ env.SDK_NAME }}-build.tgz .

- name: Print built libraries
Expand Down Expand Up @@ -782,6 +784,7 @@ jobs:
- name: Use GitHub API to start workflow
shell: bash
run: |
pip install -r scripts/gha/requirements.txt
if [[ -z ${USE_EXPANDED_MATRIX} ]]; then
USE_EXPANDED_MATRIX=0
fi
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,7 @@ jobs:
npm install -g firebase-tools
firebase emulators:start --only firestore --project demo-example &
- name: Run Android integration tests on Emulator locally
timeout-minutes: 60
timeout-minutes: 90
if: steps.get-device-type.outputs.device_type == 'virtual'
run: |
python scripts/gha/test_simulator.py --testapp_dir testapps \
Expand Down
6 changes: 3 additions & 3 deletions admob/src/include/firebase/admob/banner_view.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,21 +99,21 @@ class BannerView : public AdView {
///
/// param[in] listener A listener object which will be invoked when lifecycle
/// events occur on this AdView.
void SetAdListener(AdListener *listener) override;
void SetAdListener(AdListener* listener) override;

/// Sets a listener to be invoked when the Ad's bounding box
/// changes size or location.
///
/// param[in] listener A listener object which will be invoked when the ad
/// changes size, shape, or position.
void SetBoundingBoxListener(AdViewBoundingBoxListener *listener) override;
void SetBoundingBoxListener(AdViewBoundingBoxListener* listener) override;

/// Sets a listener to be invoked when this ad is estimated to have earned
/// money.
///
/// param[in] A listener object to be invoked when a paid event occurs on the
/// ad.
void SetPaidEventListener(PaidEventListener *listener) override;
void SetPaidEventListener(PaidEventListener* listener) override;

/// Moves the @ref BannerView so that its top-left corner is located at
/// (x, y). Coordinates are in pixels from the top-left corner of the screen.
Expand Down
2 changes: 1 addition & 1 deletion admob/src/include/firebase/admob/rewarded_ad.h
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ class RewardedAd {
/// ServerSideVerificationOptions object containing custom data and a user
/// Id.
void SetServerSideVerificationOptions(
const ServerSideVerificationOptions &serverSideVerificationOptions);
const ServerSideVerificationOptions& serverSideVerificationOptions);

private:
// An internal, platform-specific implementation object that this class uses
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,16 @@
/**
* Helper class for initializing the AdMob SDK.
*/
public final class AdMobInitializationHelper {
public final class AdMobInitializationHelper {
public static void initializeAdMob(Context context) {
MobileAds.initialize(context, new OnInitializationCompleteListener() {
@Override
public void onInitializationComplete(InitializationStatus initializationStatus) {
initializationCompleteCallback(initializationStatus);
}
});
}

public static native void initializationCompleteCallback(InitializationStatus initializationStatus);
}

public static native void initializationCompleteCallback(
InitializationStatus initializationStatus);
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
* into their (typically more complicated) Java equivalents.
*/
public class AdRequestHelper {

public AdRequestHelper() {}

/**
Expand Down
Loading