Skip to content

Add a delay to the Analytics test app. #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2021
Merged

Add a delay to the Analytics test app. #788

merged 3 commits into from
Dec 4, 2021

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Dec 3, 2021 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Since updating to Firebase iOS 8.10.0, the Analytics integration test finishes too quickly for FTL. This adds a delay to the end of the app.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration tests run.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@google-cla google-cla bot added the cla: yes label Dec 3, 2021
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Dec 3, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit 33c1963
Last updated: Fri Dec 3 21:49 PST 2021
View integration test log & download artifacts

@jonsimantov jonsimantov marked this pull request as ready for review December 3, 2021 23:39
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Dec 3, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 3, 2021
@jonsimantov jonsimantov requested a review from sunmou99 December 4, 2021 01:32
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Dec 4, 2021
@jonsimantov jonsimantov enabled auto-merge (squash) December 4, 2021 01:33
sunmou99
sunmou99 approved these changes Dec 4, 2021
View reviewed changes
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

analytics/integration_test/src/integration_test.cc

// The Analytics integration test is too fast for FTL, so pause a few seconds
// here.
ProcessEvents(1000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about ProcessEvents(5000)

@jonsimantov jonsimantov merged commit 33c1963 into main Dec 4, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Dec 4, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 4, 2021
@sunmou99 sunmou99 deleted the bugfix/analytics-itest branch December 4, 2021 08:54
@firebase firebase locked and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sunmou99 sunmou99 sunmou99 approved these changes

Assignees

@sunmou99 sunmou99

Labels
cla: yes skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @sunmou99