firebase-functions-test v3 (major version bump) #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V4 Functions SDK does not expose the config singleton directly. Use the internal-only `resetCache` function instead.
1. Replace all use of __trigger annotation to __endpoint 2. Correct import path for Expression class/type
… 2 (#178) We also pin down peer dep requirement for firebase-admin to peer dependencies required for v4 firebase-functions sdk.
TheIronDev
reviewed
Oct 14, 2022
| "firebase-admin": ">=6.0.0", | ||
| "firebase-functions": ">=3.23.0", | ||
| "firebase-admin": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0", | ||
| "firebase-functions": "^4.0.0", |
There was a problem hiding this comment.
Tagged versions don't get picked up with ^ or >.
You might want to update this to include the tag?
"firebase-functions": "^4.0.0 || 4.0.0-rc.0",
There was a problem hiding this comment.
Since we are about to release 4.0.0 anyway, I think it's safe to keep things as is.
TheIronDev
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING
The test SDK v2 works with Firebase Functions SDK v4 and above.