Skip to content

Fix module name for Promises and Protobuf #10073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2022
Merged

Fix module name for Promises and Protobuf #10073

merged 2 commits into from
Aug 9, 2022

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Aug 5, 2022

Fix #10071

@paulb777 paulb777 added this to the 9.5.0 - M120 milestone Aug 5, 2022
@paulb777 paulb777 mentioned this pull request Aug 5, 2022
Closed
@paulb777 paulb777 requested a review from ncooke3 August 5, 2022 20:26
ncooke3
ncooke3 approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for digging into this one!

@paulb777 paulb777 merged commit 879d0b4 into master Aug 9, 2022
@paulb777 paulb777 deleted the pb-zip-promises branch August 9, 2022 15:07
@paulb777 paulb777 mentioned this pull request Sep 7, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: core release-tooling
Projects
None yet
Milestone
9.5.0 - M120
Development

Successfully merging this pull request may close these issues.

Linking FirebaseInstallation fails with lld
3 participants
@paulb777 @ncooke3 @google-oss-bot