Skip to content

Fix priority inversion issue exposed by Xcode 14 #10144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2022
Merged

Fix priority inversion issue exposed by Xcode 14 #10144

merged 1 commit into from
Aug 26, 2022

Conversation

paulb777
Copy link
Member

Fix #10130

@google-oss-bot
Copy link

Size Report 1

Affected Products

  • FirebaseDatabase

    TypeBase (0ca75ea)Merge (169b503)Diff
    CocoaPods1.40 MB1.42 MB+16.5 kB (+1.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LE370Q4JPz.html

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from 57.03% (0ca75ea) to 57.04% (169b503) by +0.00%.

    FilenameBase (0ca75ea)Merge (169b503)Diff
    FSRWebSocket.m38.43%38.52%+0.09%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yD0aooEKZ1.html

@paulb777 paulb777 merged commit 737700d into master Aug 26, 2022
@paulb777 paulb777 deleted the pb-xc14-socket-rocket branch August 26, 2022 18:04
charlotteliang pushed a commit that referenced this pull request Aug 31, 2022
@paulb777 @charlotteliang
Fix priority inversion issue exposed by Xcode 14 (#10144)
abcc411
@firebase firebase locked and limited conversation to collaborators Sep 26, 2022
@paulb777
Copy link
Member Author

paulb777 commented May 3, 2024 •
edited
Loading

Upstream followed in facebookincubator/SocketRocket#651

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

@charlotteliang charlotteliang charlotteliang approved these changes

@maneesht maneesht Awaiting requested review from maneesht

Assignees
No one assigned
Labels
api: database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thread Performance Issue on Xcode 14 beta 5
4 participants
@paulb777 @google-oss-bot @morganchen12 @charlotteliang