Skip to content

[MLModelDownloader] Disable keychain-dependent tests on macCatalyst and macOS #10148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2022

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Aug 27, 2022

Context

Future work

#no-changelog

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish GitHub had an ignore blank changes options....

LGTM on green CI

@ncooke3 ncooke3 merged commit f8ee68b into master Aug 28, 2022
@ncooke3 ncooke3 deleted the nc/mlmodel-keychain-disable-tests branch August 28, 2022 05:21
@firebase firebase locked and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants