Skip to content

Test and Changelog for 10370 #10379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2022
Merged

Test and Changelog for 10370 #10379

merged 2 commits into from
Oct 19, 2022

Conversation

paulb777
Copy link
Member

Follow up to #10370

maneesht
maneesht approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@maneesht maneesht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link

google-oss-bot commented Oct 19, 2022 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseStorage

    TypeBase (d04d522)Merge (c9e0de4)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/txWv69noeW.html

@google-oss-bot
Copy link

google-oss-bot commented Oct 19, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseStorage-iOS-FirebaseStorage.framework

    Overall coverage changed from ? (d04d522) to 0.00% (c9e0de4) by ?.

    21 individual files with coverage change

    FilenameBase (d04d522)Merge (c9e0de4)Diff
    AsyncAwait.swift?0.00%?
    Result.swift?0.00%?
    Storage.swift?0.00%?
    StorageComponent.swift?0.00%?
    StorageDeleteTask.swift?0.00%?
    StorageDownloadTask.swift?0.00%?
    StorageError.swift?0.00%?
    StorageGetDownloadURLTask.swift?0.00%?
    StorageGetMetadataTask.swift?0.00%?
    StorageListResult.swift?0.00%?
    StorageListTask.swift?0.00%?
    StorageMetadata.swift?0.00%?
    StorageObservableTask.swift?0.00%?
    StoragePath.swift?0.00%?
    StorageReference.swift?0.00%?
    StorageTask.swift?0.00%?
    StorageTaskSnapshot.swift?0.00%?
    StorageTokenAuthorizer.swift?0.00%?
    StorageUpdateMetadataTask.swift?0.00%?
    StorageUploadTask.swift?0.00%?
    StorageUtils.swift?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0BnjxCHjKW.html

@paulb777 paulb777 merged commit 77e7b23 into master Oct 19, 2022
@paulb777 paulb777 deleted the pb-stor370 branch October 19, 2022 16:54
@firebase firebase locked and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maneesht maneesht maneesht approved these changes

@andrewheard andrewheard Awaiting requested review from andrewheard

Assignees
No one assigned
Labels
api: storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @maneesht