Skip to content

Switched HTTPSCallable to Async Method #14085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yakovmanshin
Copy link
Contributor

  • On all officially supported platform versions (iOS 13, Catalyst 13, macOS 10.15, tvOS 13, watchOS 7), HTTPSCallable always uses the async / await implementation of Functions’s callFunction to prevent any potential discrepancies in behavior
  • Older versions (which aren’t supported officially but can technically be used via SPM) continue calling the old (completion handler-based) method

* On all officially supported platform versions (iOS 13, Catalyst 13, macOS 10.15, tvOS 13, watchOS 7), `HTTPSCallable` always uses the async / await implementation of `Functions`’s `callFunction` to prevent any potential discrepancies in behavior
* Older versions (which aren’t supported officially but can technically be used via SPM) continue calling the old (completion handler-based) method
* Added a missing override to `MockFunctions`
@ncooke3 ncooke3 self-assigned this Nov 14, 2024
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ncooke3 ncooke3 merged commit 15caf49 into firebase:main Nov 18, 2024
38 checks passed
@yakovmanshin yakovmanshin deleted the switched-HTTPSCallable-to-async-method branch November 18, 2024 20:07
@firebase firebase locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants