[vertex-ai] Check for Swift 6 warnings

[paulb777]

Update CI after #14504

#no-changelog

[gemini-code-assist]

Hello @paulb777, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the CI configuration file .github/workflows/vertexai.yml to remove the --allow-warnings flag when running Swift 6.0 checks on macOS 15. The change effectively enforces that the project must compile without warnings under Swift 6.0 in the CI environment.

Highlights

• CI Configuration Update: The pull request modifies the CI workflow to remove the temporary allowance of warnings when building with Swift 6.0.
• Swift 6.0 Warnings: The change ensures that the project must now pass Swift 6.0 checks without any warnings in the CI environment.

Changelog

• .github/workflows/vertexai.yml
  • Removed the --allow-warnings flag for Swift 6.0 builds on macOS 15, enforcing no warnings.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Did you know?

Swift was designed to be safer than its predecessor, Objective-C, by encouraging developers to write code that avoids common programming errors.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request updates the CI configuration to check for Swift 6 warnings in the FirebaseVertexAI project. The primary change involves removing the --allow-warnings flag when building with Swift 6. This is a good step towards ensuring code quality and identifying potential issues with the codebase as it evolves with newer Swift versions.

Summary of Findings

• Unresolved TODO: The removal of --allow-warnings exposes underlying warnings that should be addressed. The original TODO comment indicates that there are remaining warnings in GenerativeAIService that need to be fixed. These warnings should be resolved to ensure code quality and prevent potential issues in the future.

Merge Readiness

The pull request is a step in the right direction by enabling Swift 6 checks. However, the unresolved TODO and the potential for exposed warnings in GenerativeAIService suggest that further investigation and code changes are necessary before merging. I am unable to approve this pull request, and recommend that it not be merged until the underlying warnings are addressed and the TODO is resolved.

As pointed out in the description, the warnings were resolved in a previous PR