-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[VertexAI] Add schema minItems/maxItems test #14703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The code adds a new test case generateContentSchemaItems
to verify the minItems
and maxItems
constraints in the response schema. The test configures a generative model with a schema that specifies an array of city names with a minimum of 3 items and a maximum of 5 items. It then sends a prompt to the model and verifies that the response contains a JSON array with the expected number of cities. Overall, this is a good addition to ensure the proper functioning of the schema validation feature.
Merge Readiness
The code changes introduce a new test case, and the implementation is well-done. I would recommend merging this pull request, but I am unable to directly approve it. Please have others review and approve this code before merging.
FirebaseVertexAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Outdated
Show resolved
Hide resolved
FirebaseVertexAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Outdated
Show resolved
Hide resolved
FirebaseVertexAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Outdated
Show resolved
Hide resolved
How about |
#no-changelog
Test for #14671