Skip to content

Correct typo in browser support error message #4306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 18, 2021

Conversation

creativecreatorormaybenot
Copy link
Contributor

Discussion

Changes

I am not sure if packages-exp requires manual changes, however, I could not (quickly) find anything in the contributing guide.

@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2021

⚠️ No Changeset found

Latest commit: 18bc6a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1
Copy link
Member

Feiyang1 commented Feb 2, 2021

Thanks for the contribution!

@google-cla google-cla bot added the cla: yes label Oct 16, 2021
@creativecreatorormaybenot
Copy link
Contributor Author

@Feiyang1 @zwu52 do you want to merge this? It has been a while, so I have now updated the branch to use resolve all merge conflicts.

It seems like packages-exp has been deleted in the meantime.

@hsubox76
Copy link
Contributor

Sorry we missed this, we usually assume contributors will merge after approval, but I think outside contributors can't merge.

@hsubox76 hsubox76 merged commit 7092f5f into firebase:master Oct 18, 2021
@firebase firebase locked and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported browser error message has a typo
4 participants