Skip to content

get() server data must be indexed #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 24, 2021
Merged

get() server data must be indexed #4796

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
de34b1b
`get()` server data must be indexed + transaction fix
jmwski Apr 15, 2021
2481792
remove transaction stuff
jmwski May 11, 2021
b483790
changeset
jmwski May 11, 2021
d795ff6
changeset
jmwski May 11, 2021
156b84f
remove extra
jmwski May 11, 2021
0ef4c5b
Merge branch 'master' into jw/get-index-fix
jmwski May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rotten-wombats-shop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/database': patch
---

Index server data retrieved by get()
4 changes: 3 additions & 1 deletion packages/database/src/core/Repo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,9 @@ export function repoGetValue(repo: Repo, query: QueryContext): Promise<Node> {
}
return repo.server_.get(query).then(
payload => {
const node = nodeFromJSON(payload as string);
const node = nodeFromJSON(payload as string).withIndex(
query._queryParams.getIndex()
);
const events = syncTreeApplyServerOverwrite(
repo.serverSyncTree_,
query._path,
Expand Down