Fei v9 main firestore #5319

Feiyang1 · 2021-08-18T06:05:35Z

No description provided.

changeset-bot · 2021-08-18T06:05:38Z

⚠️ No Changeset found

Latest commit: 13339f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Feiyang1 · 2021-08-18T06:16:38Z

packages/firestore/package.json

@@ -33,31 +29,32 @@
    "test:lite:prod": "node ./scripts/run-tests.js --platform node_lite --main=lite/index.ts 'test/lite/**/*.test.ts'",
    "test:lite:browser": "karma start --single-run --lite",
    "test:lite:browser:debug": "karma start --browsers=Chrome --lite --auto-watch",
+    "pretest": "yarn test:prepare",


Unlike the database PR, all tests including the compat tests remain in the main firestore package. I tried to move compat tests to firestore-compat, but it got really messy and requires exporting a lot of internal symbols from the main package.

pretest copies source code from firestore-compat to the compat folder in the main package, and replaces import path from @firebase/firestore to directly point to source code in the main package. This recreates the code structure before the split, so tests run correctly.

@schmidt-sebastian

However there are 2 issues I haven't figure out, and need your help:

test:node:prod doesn't run

There are 2 failing tests when running test:browser

Thanks!

I will take a lot this morning.

github-actions · 2021-08-18T06:40:07Z

Changeset File Check ⚠️

Changeset formatting error in following file:

Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

packages/firestore-compat/.eslintrc.js

packages/firestore-compat/README.md

packages/firestore-compat/package.json

packages/firestore-compat/rollup.config.js

packages/firestore/index.console.ts

schmidt-sebastian · 2021-08-18T15:08:31Z

packages/firestore/package.json

@@ -33,31 +29,32 @@
    "test:lite:prod": "node ./scripts/run-tests.js --platform node_lite --main=lite/index.ts 'test/lite/**/*.test.ts'",
    "test:lite:browser": "karma start --single-run --lite",
    "test:lite:browser:debug": "karma start --browsers=Chrome --lite --auto-watch",
+    "pretest": "yarn test:prepare",


I will take a lot this morning.

schmidt-sebastian · 2021-08-18T15:12:32Z

packages/firestore/scripts/prepare-test.ts

+
+prepareTest();
+
+function prepareTest() {


Have you tried just updating the import paths, similar to what we do for platform injection?

https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore/rollup.shared.js#L65

I also wonder if this new setup makes is hard to use IDEs to run the test since the won't invoke this rule.

I don't think that it work for node tests?
For sure it's one more thing you need to do, but you only have to do it once.

I think long term, we want to rewrite these tests and remove the dependencies on the compat layer.

* Always block on Auth * Don't block on token if already recevied

* compile firestore * update typings path * compile firestore compat * lint compat * make test work * get most tests work * build * remove special paths * update firestore-compat pkg json * fix merge issues * Simplify bundles * Prettier * Fix Bundle compile * Fix build * address comments * console build * Fix all tests * Prettier * fix merge issues * fix typo * update paths * app-exp * fix lint * correct path * fix * fix compat lint * fix firestore integration * fix workflow * update dep * Always block on Auth (#5340) * Always block on Auth * Don't block on token if already recevied * fix lint * build firestore * remove memory only tests * fix firebase integration tests * enable more build and tests * add firestore-compat to firebase dep * fix auth compat class * enable auth test * auth package doc * Update API reports Co-authored-by: Sebastian Schmidt <[email protected]> Co-authored-by: Feiyang1 <[email protected]>

* Split storage and storage-compat (#5271) * separate storage-compat from storage * commit * fix tests * wat? * build storage-compat * save * fixing some compat tests * format * update import path * format * get compat tests to work * format * update package json * cleanup * format * address comments * Update packages/storage-compat/test/unit/service.test.ts Co-authored-by: Christina Holland <[email protected]> * add missing dev dep * Update packages/storage-compat/package.json * Update packages/storage-compat/package.json * Update deps after v8 release * update compat version * Split database and database-compat (#5276) * compile database * pass database tests * compile and test database-compat * pass all tests * prettier * cleanup * fix lint * address comments * what is going on with ci * use correct case in import path * uppercase * rename * fix component name * Repo refactoring for v9 (#5325) * rename folders * rename folders * migrate app and app-compat * migrate installations and analytics * migrate app check * migrate auth * migrate functions * migrate messaging * migrate performance * migrate remoteconfig * remove v8 code * update versions * migrate firebase * fix merge issues * save * fix firebase builds * update changeset config * update build scripts * update release script * fix functions typings * remove redundant typings * update path * treat external dependencies correctly * fix lint * remove firestore-compat references * fix build issues * update build scripts * update pkg json * fix test * fix some tests * fix some tests * fix integration tests * fixes * fix dep * update ci tests * resolve todos * remove exp references * docgen build * export FirebaseError (#5349) * firebase packaging update (#5348) * Fei v9 main firestore (#5319) * compile firestore * update typings path * compile firestore compat * lint compat * make test work * get most tests work * build * remove special paths * update firestore-compat pkg json * fix merge issues * Simplify bundles * Prettier * Fix Bundle compile * Fix build * address comments * console build * Fix all tests * Prettier * fix merge issues * fix typo * update paths * app-exp * fix lint * correct path * fix * fix compat lint * fix firestore integration * fix workflow * update dep * Always block on Auth (#5340) * Always block on Auth * Don't block on token if already recevied * fix lint * build firestore * remove memory only tests * fix firebase integration tests * enable more build and tests * add firestore-compat to firebase dep * fix auth compat class * enable auth test * auth package doc * Update API reports Co-authored-by: Sebastian Schmidt <[email protected]> Co-authored-by: Feiyang1 <[email protected]> * rebasing * Create registerMessagingCompat.ts * Add changeset for v9 (#5350) * add changeset * publish messaging interop * add firestore bumps * update changeset * Revert "Create registerMessagingCompat.ts" This reverts commit 0b95a51. * Revert "rebasing" This reverts commit a8bf697. * Update index.d.ts (#5355) * Fix Context Check in `Messaging-Compat` (#5353) * Add Rules Unit Testing v2 skeleton for v9 release (#5352) * Reset package for next major version. * Switch emulator script to node-fetch. * Migrate the other request call to fetch. * Update packages/rules-unit-testing/package.json Co-authored-by: Feiyang <[email protected]> * Create stale-ducks-live.md * Revert version change. Co-authored-by: Feiyang <[email protected]> * fix import path (#5356) * Add new types and function stubs for RUT vNext. (#5316) * Add new types and function stubs. * Fix types for testEnv.emulators. * Add util functions. * Add withFunctionTriggersDisabled overloads. * Improve typing for EmulatorConfig. * Fix tests. * Rename test_environment.ts to initialize.ts. * Add a dummy test to make CI pass. * Implement emulators discovery in RUTv2. (#5334) * Add new types and function stubs. * Fix types for testEnv.emulators. * Add util functions. * Add withFunctionTriggersDisabled overloads. * Improve typing for EmulatorConfig. * Fix tests. * Rename test_environment.ts to initialize.ts. * Add a dummy test to make CI pass. * Implement emulators discovery. * Use URL object from global. * Fix unreachable error code. * Implement most of RUTv2 features. (#5343) * Implement most of RUTv2 features. * Switch to compat instances. * Remove legacy code. * Use public typings for release (#5358) * use public typings for storage * use public typings for database * Implement rest of RUTv2 features. (#5360) * Implement loading rules and withFunctionTriggersDisabled. * Implement clearFirestore and storage. * Add missing await. * Add default bucketUrl. * Use alternative method to clear bucket. * Use default param (review feedback). * Storage typing updates (#5359) * rename to StorageError * more type safety * Update API reports * update api report Co-authored-by: Feiyang1 <[email protected]> * correct component name * fix installtions-compat typing * remove rules-unit-testing from ignore list * reenable things * support mjs files * correct matching pattern * transform only @firebase/util * use public types for database doc * transform all but compat packages Co-authored-by: Sebastian Schmidt <[email protected]> Co-authored-by: Feiyang1 <[email protected]> Co-authored-by: kai <[email protected]> Co-authored-by: Yuchen Shi <[email protected]> Co-authored-by: Kai Wu <[email protected]>

Feiyang1 added 9 commits August 13, 2021 23:37

compile firestore

00d5618

update typings path

e072423

compile firestore compat

61326d0

lint compat

6d3a95c

make test work

fb89c68

get most tests work

e9039e5

build

b7c9e77

remove special paths

25a9dea

update firestore-compat pkg json

5bff131

Feiyang1 assigned schmidt-sebastian Aug 18, 2021

Feiyang1 requested review from hiranya911 and hsubox76 as code owners August 18, 2021 06:05

Feiyang1 commented Aug 18, 2021

View reviewed changes

Feiyang1 added 2 commits August 17, 2021 23:27

Merge branch 'master' into fei-v9-main-firestore

e475b43

fix merge issues

2cb9567

Feiyang1 requested review from avolkovi, egilmorez, jsdt, sam-gc, schmidt-sebastian, yuchenshi and zwu52 as code owners August 18, 2021 06:37

schmidt-sebastian reviewed Aug 18, 2021

View reviewed changes

schmidt-sebastian and others added 5 commits August 18, 2021 10:30

Simplify bundles

ae2d146

Prettier

0ea42e3

Fix Bundle compile

bfdf412

Fix build

f73c1b5

address comments

8a9eb9f

Feiyang1 and others added 19 commits August 20, 2021 14:14

app-exp

8be6e79

fix lint

070f093

correct path

c78cb57

fix

bf408d4

fix compat lint

609419d

fix firestore integration

196d0e6

fix workflow

031942a

update dep

b03423b

Always block on Auth (#5340)

aa5b344

* Always block on Auth * Don't block on token if already recevied

fix lint

0bdf7f2

Merge branch 'fei-v9-main' into fei-v9-main-firestore

b417bbe

build firestore

6655e90

remove memory only tests

0adb499

fix firebase integration tests

1b46468

enable more build and tests

0b43ba7

add firestore-compat to firebase dep

60b2f0a

fix auth compat class

6577316

enable auth test

07c6ee3

auth package doc

8481938

Feiyang1 requested a review from bojeil-google as a code owner August 23, 2021 02:34

Update API reports

13339f8

Feiyang1 mentioned this pull request Aug 23, 2021

Add changeset for v9 #5350

Merged

schmidt-sebastian approved these changes Aug 23, 2021

View reviewed changes

Feiyang1 merged commit 736cc88 into fei-v9-main Aug 23, 2021

Feiyang1 deleted the fei-v9-main-firestore branch August 23, 2021 18:11

firebase locked and limited conversation to collaborators Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fei v9 main firestore #5319

Fei v9 main firestore #5319

Feiyang1 commented Aug 18, 2021

changeset-bot bot commented Aug 18, 2021 •

edited

Loading

Feiyang1 Aug 18, 2021

Feiyang1 Aug 18, 2021

schmidt-sebastian Aug 18, 2021

github-actions bot commented Aug 18, 2021 •

edited

Loading

schmidt-sebastian Aug 18, 2021

schmidt-sebastian Aug 18, 2021

Feiyang1 Aug 18, 2021

Fei v9 main firestore #5319

Fei v9 main firestore #5319

Conversation

Feiyang1 commented Aug 18, 2021

changeset-bot bot commented Aug 18, 2021 • edited Loading

⚠️ No Changeset found

Feiyang1 Aug 18, 2021

Choose a reason for hiding this comment

Feiyang1 Aug 18, 2021

Choose a reason for hiding this comment

schmidt-sebastian Aug 18, 2021

Choose a reason for hiding this comment

github-actions bot commented Aug 18, 2021 • edited Loading

Changeset File Check ⚠️

schmidt-sebastian Aug 18, 2021

Choose a reason for hiding this comment

schmidt-sebastian Aug 18, 2021

Choose a reason for hiding this comment

Feiyang1 Aug 18, 2021

Choose a reason for hiding this comment

changeset-bot bot commented Aug 18, 2021 •

edited

Loading

github-actions bot commented Aug 18, 2021 •

edited

Loading