Skip to content

Misc source cleanup for Firebase Storage #5467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

This is a cleanup PR to reduce the diff for #4973

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2021

⚠️ No Changeset found

Latest commit: de302d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

if (canceled) {
backoffCallback(false, new RequestEndStatus(false, null, true));
return;
}
const connection = self.pool_.createConnection();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so nostalgic

@schmidt-sebastian schmidt-sebastian merged commit addd8b1 into master Sep 28, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/cleanup branch September 28, 2021 16:19
@firebase firebase locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants