Skip to content

Revert "Update dependency ora to v6" #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2021
Merged

Revert "Update dependency ora to v6" #5640

merged 1 commit into from
Oct 20, 2021

Conversation

Feiyang1
Copy link
Member

Reverts #5406
v6 breaks our scripts - see #5406 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2021

⚠️ No Changeset found

Latest commit: e6f648e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 20, 2021
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (69ff8eb) and head commit (9028911).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (69ff8eb) and head commit (9028911).

hsubox76
hsubox76 approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't see the comment!

@Feiyang1 Feiyang1 merged commit f1c38f3 into master Oct 20, 2021
@Feiyang1 Feiyang1 deleted the revert-5406-renovate/ora-6.x branch October 20, 2021 17:50
@firebase firebase locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@hsubox76 hsubox76

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Feiyang1 @google-oss-bot @hsubox76