Skip to content

Fix Firestore build #5829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Fix Firestore build #5829

merged 1 commit into from
Dec 21, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

This fixes an error in the JS build that has been showing up for me locally. It was introduced in #5808. Note that the error did not prevent the break the build - so that is a bit strange.

The main change here is that IndexedDbRemoteDocument cache goes back to the state before the PR and continues to use MutableDocuments.

@changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2021

⚠️ No Changeset found

Latest commit: 17ae09e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (9295bb0) and head commit (0caecbf).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (9295bb0) and head commit (0caecbf).

@schmidt-sebastian schmidt-sebastian merged commit 9ca74ee into master Dec 21, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fixbuild3 branch December 21, 2021 21:30
@firebase firebase locked and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants