[Auth] Add missing field to firebase claim in token result #6234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bad61c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yuchenshi
approved these changes
May 5, 2022
lisajian
approved these changes
May 5, 2022
Size Report 1Affected ProductsNo changes between base commit (d38eced) and merge commit (355620f).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (d38eced) and merge commit (355620f).Test Logs |
egilmorez
approved these changes
May 9, 2022
.changeset/cool-elephants-leave.md
Outdated
| "@firebase/auth": patch | ||
| --- | ||
|
|
||
| Add missing field to firebase claim in token result typing |
There was a problem hiding this comment.
Should Firebase be capped here, or is it firebase a literal?
There was a problem hiding this comment.
Firebase literal, should I put it in backticks?
There was a problem hiding this comment.
Updated for backticks
sam-gc
force-pushed
the
sam-gc/firebase-identities
branch
from
c01b607 to
bad61c6
Compare
lisajian
approved these changes
May 9, 2022
yuchenshi
approved these changes
May 9, 2022
hsubox76
approved these changes
May 9, 2022
This was referenced May 24, 2022
Closed
Closed
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6218