Fix e2e tests #6238

hsubox76 · 2022-05-06T00:13:25Z

I think the E2E tests were failing (https://github.com/firebase/firebase-js-sdk/actions/runs/2278640484) because karma-typescript was trying to grab the cjs module for idb and karma-typescript config doesn't allow specifying module fields preferences. This fixes it locally, will see how it runs on CI after merged.

changeset-bot · 2022-05-06T00:13:28Z

⚠️ No Changeset found

Latest commit: e393c96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2022-05-06T00:31:45Z

Size Report ¹

Affected Products

@firebase/database
Type Base (1ac3c9d) Merge (0f9fedc) Diff
browser 248 kB 248 kB -69 B (-0.0%)
esm5 276 kB 276 kB -52 B (-0.0%)
main 281 kB 281 kB -52 B (-0.0%)
module 248 kB 248 kB -69 B (-0.0%)
@firebase/database-compat/standalone
Type Base (1ac3c9d) Merge (0f9fedc) Diff
main 370 kB 370 kB -52 B (-0.0%)

`bundle`

Type	Base (`1ac3c9d`)	Merge (`0f9fedc`)	Diff
database (Append to a list of data)	145 kB	145 kB	-89 B (-0.1%)
database (Filtering data)	144 kB	144 kB	-89 B (-0.1%)
database (Listen for child events)	160 kB	160 kB	-89 B (-0.1%)
database (Listen for value events + Detach listeners)	160 kB	160 kB	-89 B (-0.1%)
database (Listen for value events)	160 kB	160 kB	-89 B (-0.1%)
database (Read data once)	152 kB	152 kB	-89 B (-0.1%)
database (Save data as transactions)	162 kB	162 kB	-89 B (-0.1%)
database (Sort data)	146 kB	146 kB	-89 B (-0.1%)
database (Write data)	144 kB	144 kB	-89 B (-0.1%)

firebase
Type Base (1ac3c9d) Merge (0f9fedc) Diff
firebase-compat.js 783 kB 783 kB -84 B (-0.0%)
firebase-database-compat.js 166 kB 166 kB -84 B (-0.1%)
firebase-database.js 604 kB 604 kB -134 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/3atV8UwyPV.html

google-oss-bot · 2022-05-06T00:55:41Z

Size Analysis Report ¹

Affected Products

@firebase/database
- DataSnapshot
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- Database
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- OnDisconnect
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 120 kB 120 kB -126 B (-0.1%)
  size-with-ext-deps 141 kB 141 kB -89 B (-0.1%)
- QueryConstraint
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- TransactionResult
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _QueryImpl
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _QueryParams
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _ReferenceImpl
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _TEST_ACCESS_forceRestClient
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _TEST_ACCESS_hijackHash
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _repoManagerDatabaseFromApp
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _setSDKVersion
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _validatePathString
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _validateWritablePath
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- child
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- connectDatabaseEmulator
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- enableLogging
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- endAt
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 118 kB 118 kB -126 B (-0.1%)
  size-with-ext-deps 139 kB 139 kB -89 B (-0.1%)
- endBefore
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 119 kB 119 kB -126 B (-0.1%)
  size-with-ext-deps 140 kB 140 kB -89 B (-0.1%)
- equalTo
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 119 kB 119 kB -126 B (-0.1%)
  size-with-ext-deps 140 kB 140 kB -89 B (-0.1%)
- forceLongPolling
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- forceWebSockets
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- get
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 124 kB 124 kB -126 B (-0.1%)
  size-with-ext-deps 145 kB 145 kB -89 B (-0.1%)
- getDatabase
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- goOffline
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- goOnline
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- increment
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- limitToFirst
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- limitToLast
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- off
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 124 kB 124 kB -126 B (-0.1%)
  size-with-ext-deps 145 kB 145 kB -89 B (-0.1%)
- onChildAdded
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 133 kB 133 kB -126 B (-0.1%)
  size-with-ext-deps 154 kB 154 kB -89 B (-0.1%)
- onChildChanged
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 133 kB 133 kB -126 B (-0.1%)
  size-with-ext-deps 154 kB 154 kB -89 B (-0.1%)
- onChildMoved
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 133 kB 133 kB -126 B (-0.1%)
  size-with-ext-deps 154 kB 154 kB -89 B (-0.1%)
- onChildRemoved
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 133 kB 133 kB -126 B (-0.1%)
  size-with-ext-deps 154 kB 154 kB -89 B (-0.1%)
- onDisconnect
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 120 kB 120 kB -126 B (-0.1%)
  size-with-ext-deps 141 kB 141 kB -89 B (-0.1%)
- onValue
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 133 kB 133 kB -126 B (-0.1%)
  size-with-ext-deps 154 kB 154 kB -89 B (-0.1%)
- orderByChild
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 118 kB 118 kB -126 B (-0.1%)
  size-with-ext-deps 139 kB 139 kB -89 B (-0.1%)
- orderByKey
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- orderByPriority
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- orderByValue
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- push
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 118 kB 118 kB -126 B (-0.1%)
  size-with-ext-deps 139 kB 139 kB -89 B (-0.1%)
- query
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- ref
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- refFromURL
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- remove
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- runTransaction
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 135 kB 135 kB -126 B (-0.1%)
  size-with-ext-deps 156 kB 156 kB -89 B (-0.1%)
- serverTimestamp
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- set
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- setPriority
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- setWithPriority
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- startAfter
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 119 kB 119 kB -126 B (-0.1%)
  size-with-ext-deps 140 kB 140 kB -89 B (-0.1%)
- startAt
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 118 kB 118 kB -126 B (-0.1%)
  size-with-ext-deps 139 kB 139 kB -89 B (-0.1%)
- update
  Size
  Type Base (1ac3c9d) Merge (0f9fedc) Diff
  size 118 kB 118 kB -126 B (-0.1%)
  size-with-ext-deps 139 kB 139 kB -89 B (-0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/Htjp5foiP4.html

Fix e2e tests

05b1129

hsubox76 requested a review from allspain as a code owner May 6, 2022 00:13

Formatting pass

e393c96

lahirumaramba approved these changes May 6, 2022

View reviewed changes

hsubox76 merged commit 936591c into master May 6, 2022

hsubox76 deleted the ch-e2e-fix branch May 6, 2022 17:31

firebase locked and limited conversation to collaborators Jun 6, 2022

Fix e2e tests #6238

Fix e2e tests #6238

Uh oh!

Conversation

hsubox76 commented May 6, 2022

Uh oh!

changeset-bot bot commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/database

@firebase/database-compat/standalone

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/database

DataSnapshot

Database

OnDisconnect

QueryConstraint

TransactionResult

_QueryImpl

_QueryParams

_ReferenceImpl

_TEST_ACCESS_forceRestClient

_TEST_ACCESS_hijackHash

_repoManagerDatabaseFromApp

_setSDKVersion

_validatePathString

_validateWritablePath

child

connectDatabaseEmulator

enableLogging

endAt

endBefore

equalTo

forceLongPolling

forceWebSockets

get

getDatabase

goOffline

goOnline

increment

limitToFirst

limitToLast

off

onChildAdded

onChildChanged

onChildMoved

onChildRemoved

onDisconnect

onValue

orderByChild

orderByKey

orderByPriority

orderByValue

push

query

ref

refFromURL

remove

runTransaction

serverTimestamp

set

setPriority

setWithPriority

startAfter

startAt

update

Test Logs

Uh oh!

changeset-bot bot commented May 6, 2022 •

edited

Loading

google-oss-bot commented May 6, 2022 •

edited

Loading

Size Report ¹

`@firebase/database`

`@firebase/database-compat/standalone`

`bundle`

`firebase`

google-oss-bot commented May 6, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/database`

`DataSnapshot`

`Database`

`OnDisconnect`

`QueryConstraint`

`TransactionResult`

`_QueryImpl`

`_QueryParams`

`_ReferenceImpl`

`_TEST_ACCESS_forceRestClient`

`_TEST_ACCESS_hijackHash`

`_repoManagerDatabaseFromApp`

`_setSDKVersion`

`_validatePathString`

`_validateWritablePath`

`child`

`connectDatabaseEmulator`

`enableLogging`

`endAt`

`endBefore`

`equalTo`

`forceLongPolling`

`forceWebSockets`

`get`

`getDatabase`

`goOffline`

`goOnline`

`increment`

`limitToFirst`

`limitToLast`

`off`

`onChildAdded`

`onChildChanged`

`onChildMoved`

`onChildRemoved`

`onDisconnect`

`onValue`

`orderByChild`

`orderByKey`

`orderByPriority`

`orderByValue`

`push`

`query`

`ref`

`refFromURL`

`remove`

`runTransaction`

`serverTimestamp`

`set`

`setPriority`

`setWithPriority`

`startAfter`

`startAt`

`update`