Skip to content

Propagate customData in FirebaseError when the user is disabled. #6289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2022

Conversation

prameshj
Copy link
Contributor

@prameshj prameshj commented May 23, 2022

Internal bug - b/229774279

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2022

🦋 Changeset detected

Latest commit: 21286ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines 108 to 117
let error: FirebaseError | null = null;
try {
await signInWithIdp(auth, request);
} catch (e) {
error = e;
}
expect(error!.customData!.email).to.eq("[email protected]");
expect(error!.code).to.eq(
'auth/user-disabled'
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use chai-as-promised to put all of this error testing logic into one assertion phrase. From ap/index.test.ts for example:

await expect(promise)
.to.be.rejectedWith(FirebaseError, 'auth/credential-already-in-use')
.eventually.with.deep.property('customData', {
appName: 'test-app',
_tokenResponse: response
});

i.e.

await expect(signInWithIdp(auth, request)).to.be.rejectedWith('auth/user-disabled')
    .eventually.with.deep.property('customData', {email: '[email protected]'});

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@lisajian lisajian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you attach a changeset and add an internal bug number or link to a Github issue to the PR description? Overall LGTM pending nits

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 23, 2022

Size Report 1

Affected Products

  • @firebase/auth/cordova

    TypeBase (4559c51)Merge (26f7d07)Diff
    browser183 kB183 kB+93 B (+0.1%)
    module183 kB183 kB+93 B (+0.1%)
  • @firebase/auth/internal

    TypeBase (4559c51)Merge (26f7d07)Diff
    browser166 kB166 kB+93 B (+0.1%)
    esm5216 kB216 kB+93 B (+0.0%)
    main183 kB183 kB+93 B (+0.1%)
    module166 kB166 kB+93 B (+0.1%)
  • @firebase/auth/react-native

    TypeBase (4559c51)Merge (26f7d07)Diff
    browser168 kB168 kB+93 B (+0.1%)
    module168 kB168 kB+93 B (+0.1%)
  • bundle

    TypeBase (4559c51)Merge (26f7d07)Diff
    auth (Anonymous)66.0 kB66.1 kB+59 B (+0.1%)
    auth (EmailAndPassword)70.1 kB70.2 kB+59 B (+0.1%)
    auth (GoogleFBTwitterGitHubPopup)89.9 kB90.0 kB+59 B (+0.1%)
    auth (GooglePopup)89.7 kB89.7 kB+59 B (+0.1%)
    auth (GoogleRedirect)89.9 kB89.9 kB+59 B (+0.1%)
    auth (Phone)76.1 kB76.1 kB+59 B (+0.1%)
  • firebase

    TypeBase (4559c51)Merge (26f7d07)Diff
    firebase-auth-compat.js124 kB125 kB+53 B (+0.0%)
    firebase-auth-cordova.js472 kB472 kB+222 B (+0.0%)
    firebase-auth-react-native.js495 kB495 kB+222 B (+0.0%)
    firebase-auth.js417 kB417 kB+186 B (+0.0%)
    firebase-compat.js787 kB787 kB+53 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qd5xbgWna1.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 23, 2022

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • ActionCodeOperation

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.4 kB31.5 kB+58 B (+0.2%)
      size-with-ext-deps51.0 kB51.0 kB+59 B (+0.1%)
    • ActionCodeURL

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.2 kB32.3 kB+58 B (+0.2%)
      size-with-ext-deps52.1 kB52.1 kB+59 B (+0.1%)
    • AuthCredential

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.4 kB31.5 kB+58 B (+0.2%)
      size-with-ext-deps51.0 kB51.1 kB+59 B (+0.1%)
    • AuthErrorCodes

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size35.8 kB35.9 kB+58 B (+0.2%)
      size-with-ext-deps55.4 kB55.5 kB+59 B (+0.1%)
    • EmailAuthCredential

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size33.3 kB33.4 kB+58 B (+0.2%)
      size-with-ext-deps52.9 kB53.0 kB+59 B (+0.1%)
    • EmailAuthProvider

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size34.7 kB34.8 kB+58 B (+0.2%)
      size-with-ext-deps54.6 kB54.6 kB+59 B (+0.1%)
    • FacebookAuthProvider

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size36.3 kB36.4 kB+58 B (+0.2%)
      size-with-ext-deps55.9 kB56.0 kB+59 B (+0.1%)
    • FactorId

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.2 kB31.2 kB+58 B (+0.2%)
      size-with-ext-deps50.8 kB50.8 kB+59 B (+0.1%)
    • GithubAuthProvider

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size36.3 kB36.4 kB+58 B (+0.2%)
      size-with-ext-deps55.9 kB56.0 kB+59 B (+0.1%)
    • GoogleAuthProvider

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size36.3 kB36.4 kB+58 B (+0.2%)
      size-with-ext-deps55.9 kB56.0 kB+59 B (+0.1%)
    • OAuthCredential

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size33.4 kB33.5 kB+58 B (+0.2%)
      size-with-ext-deps53.0 kB53.1 kB+59 B (+0.1%)
    • OAuthProvider

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size37.3 kB37.3 kB+58 B (+0.2%)
      size-with-ext-deps56.9 kB56.9 kB+59 B (+0.1%)
    • OperationType

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.2 kB31.3 kB+58 B (+0.2%)
      size-with-ext-deps50.8 kB50.9 kB+59 B (+0.1%)
    • PhoneAuthCredential

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size33.4 kB33.5 kB+58 B (+0.2%)
      size-with-ext-deps53.0 kB53.1 kB+59 B (+0.1%)
    • PhoneAuthProvider

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size35.1 kB35.2 kB+58 B (+0.2%)
      size-with-ext-deps54.7 kB54.8 kB+59 B (+0.1%)
    • PhoneMultiFactorGenerator

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.1 kB32.2 kB+58 B (+0.2%)
      size-with-ext-deps51.7 kB51.8 kB+59 B (+0.1%)
    • ProviderId

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.3 kB31.3 kB+58 B (+0.2%)
      size-with-ext-deps50.9 kB50.9 kB+59 B (+0.1%)
    • RecaptchaVerifier

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size37.6 kB37.6 kB+58 B (+0.2%)
      size-with-ext-deps57.2 kB57.2 kB+59 B (+0.1%)
    • SAMLAuthProvider

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size37.6 kB37.7 kB+58 B (+0.2%)
      size-with-ext-deps57.2 kB57.2 kB+59 B (+0.1%)
    • SignInMethod

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.3 kB31.4 kB+58 B (+0.2%)
      size-with-ext-deps50.9 kB50.9 kB+59 B (+0.1%)
    • TwitterAuthProvider

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size36.3 kB36.4 kB+58 B (+0.2%)
      size-with-ext-deps55.9 kB56.0 kB+59 B (+0.1%)
    • applyActionCode

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.4 kB31.4 kB+58 B (+0.2%)
      size-with-ext-deps51.0 kB51.0 kB+59 B (+0.1%)
    • beforeAuthStateChanged

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.2 kB31.3 kB+58 B (+0.2%)
      size-with-ext-deps50.8 kB50.9 kB+59 B (+0.1%)
    • browserLocalPersistence

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size34.5 kB34.6 kB+58 B (+0.2%)
      size-with-ext-deps54.2 kB54.3 kB+59 B (+0.1%)
    • browserPopupRedirectResolver

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size55.5 kB55.6 kB+58 B (+0.1%)
      size-with-ext-deps75.3 kB75.4 kB+59 B (+0.1%)
    • browserSessionPersistence

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size34.5 kB34.6 kB+58 B (+0.2%)
      size-with-ext-deps54.2 kB54.3 kB+59 B (+0.1%)
    • checkActionCode

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.3 kB32.4 kB+58 B (+0.2%)
      size-with-ext-deps51.9 kB52.0 kB+59 B (+0.1%)
    • confirmPasswordReset

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.4 kB31.5 kB+58 B (+0.2%)
      size-with-ext-deps51.0 kB51.1 kB+59 B (+0.1%)
    • connectAuthEmulator

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.9 kB32.9 kB+58 B (+0.2%)
      size-with-ext-deps52.5 kB52.5 kB+59 B (+0.1%)
    • createUserWithEmailAndPassword

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.3 kB32.4 kB+58 B (+0.2%)
      size-with-ext-deps51.9 kB51.9 kB+59 B (+0.1%)
    • debugErrorMap

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size42.3 kB42.3 kB+58 B (+0.1%)
      size-with-ext-deps61.9 kB61.9 kB+59 B (+0.1%)
    • deleteUser

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.2 kB31.2 kB+58 B (+0.2%)
      size-with-ext-deps50.8 kB50.8 kB+59 B (+0.1%)
    • fetchSignInMethodsForEmail

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.6 kB31.7 kB+58 B (+0.2%)
      size-with-ext-deps51.2 kB51.3 kB+59 B (+0.1%)
    • getAdditionalUserInfo

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.5 kB32.5 kB+58 B (+0.2%)
      size-with-ext-deps52.1 kB52.1 kB+59 B (+0.1%)
    • getAuth

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size63.2 kB63.3 kB+59 B (+0.1%)
      size-with-ext-deps83.6 kB83.7 kB+59 B (+0.1%)
    • getIdToken

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.2 kB31.3 kB+58 B (+0.2%)
      size-with-ext-deps50.8 kB50.8 kB+59 B (+0.1%)
    • getIdTokenResult

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.1 kB31.2 kB+58 B (+0.2%)
      size-with-ext-deps50.7 kB50.8 kB+59 B (+0.1%)
    • getMultiFactorResolver

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size33.9 kB33.9 kB+58 B (+0.2%)
      size-with-ext-deps53.5 kB53.5 kB+59 B (+0.1%)
    • getRedirectResult

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size38.8 kB38.9 kB+58 B (+0.1%)
      size-with-ext-deps58.4 kB58.5 kB+59 B (+0.1%)
    • inMemoryPersistence

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.2 kB31.2 kB+58 B (+0.2%)
      size-with-ext-deps50.7 kB50.8 kB+59 B (+0.1%)
    • indexedDBLocalPersistence

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size38.6 kB38.6 kB+58 B (+0.2%)
      size-with-ext-deps58.2 kB58.2 kB+59 B (+0.1%)
    • initializeAuth

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.4 kB31.5 kB+58 B (+0.2%)
      size-with-ext-deps51.5 kB51.5 kB+59 B (+0.1%)
    • isSignInWithEmailLink

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.4 kB32.4 kB+58 B (+0.2%)
      size-with-ext-deps52.2 kB52.2 kB+59 B (+0.1%)
    • linkWithCredential

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.2 kB32.2 kB+58 B (+0.2%)
      size-with-ext-deps51.8 kB51.8 kB+59 B (+0.1%)
    • linkWithPhoneNumber

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size35.9 kB35.9 kB+58 B (+0.2%)
      size-with-ext-deps55.5 kB55.5 kB+59 B (+0.1%)
    • linkWithPopup

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size42.4 kB42.4 kB+58 B (+0.1%)
      size-with-ext-deps62.0 kB62.1 kB+59 B (+0.1%)
    • linkWithRedirect

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size37.6 kB37.6 kB+58 B (+0.2%)
      size-with-ext-deps57.2 kB57.2 kB+59 B (+0.1%)
    • multiFactor

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size33.3 kB33.4 kB+58 B (+0.2%)
      size-with-ext-deps52.9 kB53.0 kB+59 B (+0.1%)
    • onAuthStateChanged

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.2 kB31.3 kB+58 B (+0.2%)
      size-with-ext-deps50.8 kB50.9 kB+59 B (+0.1%)
    • onIdTokenChanged

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.2 kB31.3 kB+58 B (+0.2%)
      size-with-ext-deps50.8 kB50.8 kB+59 B (+0.1%)
    • parseActionCodeURL

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.3 kB32.3 kB+58 B (+0.2%)
      size-with-ext-deps52.1 kB52.2 kB+59 B (+0.1%)
    • prodErrorMap

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.1 kB31.2 kB+58 B (+0.2%)
      size-with-ext-deps50.7 kB50.8 kB+59 B (+0.1%)
    • reauthenticateWithCredential

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.8 kB32.8 kB+58 B (+0.2%)
      size-with-ext-deps52.3 kB52.4 kB+59 B (+0.1%)
    • reauthenticateWithPhoneNumber

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size36.4 kB36.5 kB+58 B (+0.2%)
      size-with-ext-deps56.0 kB56.1 kB+59 B (+0.1%)
    • reauthenticateWithPopup

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size42.4 kB42.5 kB+58 B (+0.1%)
      size-with-ext-deps62.0 kB62.1 kB+59 B (+0.1%)
    • reauthenticateWithRedirect

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size37.3 kB37.4 kB+58 B (+0.2%)
      size-with-ext-deps56.9 kB57.0 kB+59 B (+0.1%)
    • reload

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.1 kB31.2 kB+58 B (+0.2%)
      size-with-ext-deps50.7 kB50.8 kB+59 B (+0.1%)
    • sendEmailVerification

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.2 kB32.3 kB+58 B (+0.2%)
      size-with-ext-deps51.8 kB51.9 kB+59 B (+0.1%)
    • sendPasswordResetEmail

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.1 kB32.2 kB+58 B (+0.2%)
      size-with-ext-deps51.7 kB51.8 kB+59 B (+0.1%)
    • sendSignInLinkToEmail

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.2 kB32.2 kB+58 B (+0.2%)
      size-with-ext-deps51.7 kB51.8 kB+59 B (+0.1%)
    • setPersistence

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.2 kB31.3 kB+58 B (+0.2%)
      size-with-ext-deps50.8 kB50.8 kB+59 B (+0.1%)
    • signInAnonymously

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.4 kB32.5 kB+58 B (+0.2%)
      size-with-ext-deps52.0 kB52.1 kB+59 B (+0.1%)
    • signInWithCredential

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.5 kB32.6 kB+58 B (+0.2%)
      size-with-ext-deps52.1 kB52.2 kB+59 B (+0.1%)
    • signInWithCustomToken

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.3 kB32.3 kB+58 B (+0.2%)
      size-with-ext-deps51.9 kB51.9 kB+59 B (+0.1%)
    • signInWithEmailAndPassword

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size36.2 kB36.3 kB+58 B (+0.2%)
      size-with-ext-deps56.0 kB56.1 kB+59 B (+0.1%)
    • signInWithEmailLink

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size36.4 kB36.5 kB+58 B (+0.2%)
      size-with-ext-deps56.2 kB56.3 kB+59 B (+0.1%)
    • signInWithPhoneNumber

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size36.2 kB36.2 kB+58 B (+0.2%)
      size-with-ext-deps55.8 kB55.9 kB+59 B (+0.1%)
    • signInWithPopup

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size42.4 kB42.4 kB+58 B (+0.1%)
      size-with-ext-deps62.0 kB62.0 kB+59 B (+0.1%)
    • signInWithRedirect

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size37.0 kB37.1 kB+58 B (+0.2%)
      size-with-ext-deps56.6 kB56.7 kB+59 B (+0.1%)
    • signOut

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.2 kB31.2 kB+58 B (+0.2%)
      size-with-ext-deps50.8 kB50.8 kB+59 B (+0.1%)
    • unlink

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.7 kB31.8 kB+58 B (+0.2%)
      size-with-ext-deps51.3 kB51.4 kB+59 B (+0.1%)
    • updateCurrentUser

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.2 kB31.3 kB+58 B (+0.2%)
      size-with-ext-deps50.8 kB50.8 kB+59 B (+0.1%)
    • updateEmail

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.5 kB31.5 kB+58 B (+0.2%)
      size-with-ext-deps51.1 kB51.1 kB+59 B (+0.1%)
    • updatePassword

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.5 kB31.5 kB+58 B (+0.2%)
      size-with-ext-deps51.1 kB51.1 kB+59 B (+0.1%)
    • updatePhoneNumber

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.9 kB32.0 kB+58 B (+0.2%)
      size-with-ext-deps51.5 kB51.6 kB+59 B (+0.1%)
    • updateProfile

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.7 kB31.7 kB+58 B (+0.2%)
      size-with-ext-deps51.2 kB51.3 kB+59 B (+0.1%)
    • useDeviceLanguage

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size31.2 kB31.2 kB+58 B (+0.2%)
      size-with-ext-deps50.8 kB50.8 kB+59 B (+0.1%)
    • verifyBeforeUpdateEmail

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.2 kB32.3 kB+58 B (+0.2%)
      size-with-ext-deps51.8 kB51.9 kB+59 B (+0.1%)
    • verifyPasswordResetCode

      Size

      TypeBase (4559c51)Merge (26f7d07)Diff
      size32.4 kB32.5 kB+58 B (+0.2%)
      size-with-ext-deps52.0 kB52.1 kB+59 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jq6JL5Ddnu.html

@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label May 23, 2022
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text string LG, thanks!

@prameshj prameshj force-pushed the user-disabled-error branch from f7f0ea9 to b304eeb Compare May 23, 2022 21:31
@prameshj
Copy link
Contributor Author

Could you attach a changeset and add an internal bug number or link to a Github issue to the PR description? Overall LGTM pending nits

Thanks! I am having trouble reproing the fix in the demo app now. I will submit the changeset once I resolve that.

@lisajian
Copy link
Contributor

SG, thanks! Giving a preemptive LGTM in the meantime. Thanks for the fix!

Could you attach a changeset and add an internal bug number or link to a Github issue to the PR description? Overall LGTM pending nits

Thanks! I am having trouble reproing the fix in the demo app now. I will submit the changeset once I resolve that.

@prameshj prameshj force-pushed the user-disabled-error branch from b304eeb to e980360 Compare May 24, 2022 22:03
@prameshj prameshj merged commit 88517b5 into master May 26, 2022
@prameshj prameshj deleted the user-disabled-error branch May 26, 2022 00:03
This was referenced May 27, 2022
@firebase firebase locked and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
doc-changes PRs that affect docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants