Propagate customData in FirebaseError when the user is disabled. #6289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prameshj
requested review from
avolkovi,
lisajian,
sam-gc and
yuchenshi
as code owners
🦋 Changeset detectedLatest commit: 21286ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lisajian
reviewed
May 23, 2022
sam-gc
reviewed
May 23, 2022
Comment on lines
108
to
117
| let error: FirebaseError | null = null; | ||
| try { | ||
| await signInWithIdp(auth, request); | ||
| } catch (e) { | ||
| error = e; | ||
| } | ||
| expect(error!.customData!.email).to.eq("[email protected]"); | ||
| expect(error!.code).to.eq( | ||
| 'auth/user-disabled' | ||
| ); |
There was a problem hiding this comment.
You can use chai-as-promised to put all of this error testing logic into one assertion phrase. From ap/index.test.ts for example:
firebase-js-sdk/packages/auth/src/api/index.test.ts
Lines 178 to 183 in b6196d2
i.e.
await expect(signInWithIdp(auth, request)).to.be.rejectedWith('auth/user-disabled')
.eventually.with.deep.property('customData', {email: '[email protected]'});
lisajian
reviewed
May 23, 2022
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
egilmorez
approved these changes
May 23, 2022
prameshj
force-pushed
the
user-disabled-error
branch
from
f7f0ea9 to
b304eeb
Compare
Thanks! I am having trouble reproing the fix in the demo app now. I will submit the changeset once I resolve that. |
sam-gc
approved these changes
May 23, 2022
|
SG, thanks! Giving a preemptive LGTM in the meantime. Thanks for the fix!
|
lisajian
approved these changes
May 23, 2022
prameshj
force-pushed
the
user-disabled-error
branch
from
b304eeb to
e980360
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal bug - b/229774279