Skip to content

Updated readme instructions for storage #6650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2022
Merged

Updated readme instructions for storage #6650

merged 2 commits into from
Oct 3, 2022

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented Oct 3, 2022

Updated README to include CORS setup information to run Storage tests.

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: a095ea2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tonyjhuang
tonyjhuang reviewed Oct 3, 2022
View reviewed changes
tonyjhuang
tonyjhuang approved these changes Oct 3, 2022
View reviewed changes
Copy link

@tonyjhuang tonyjhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one comment

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 3, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (de32c24) and merge commit (33f0a87).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/70AwDwyNEP.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 3, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (de32c24) and merge commit (8358fb5).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ga6IT0lF7B.html

@maneesht maneesht assigned dwyfrequency and unassigned hsubox76 Oct 3, 2022
dwyfrequency
dwyfrequency reviewed Oct 3, 2022
View reviewed changes
dwyfrequency
dwyfrequency approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maneesht maneesht merged commit 629627f into master Oct 3, 2022
@maneesht maneesht deleted the mtewani/update-storage-test-instructions branch October 3, 2022 22:18
@firebase firebase locked and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

@tonyjhuang tonyjhuang tonyjhuang approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees

@dwyfrequency dwyfrequency

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maneesht @google-oss-bot @tonyjhuang @dwyfrequency @hsubox76