Skip to content

Reintroduce internal rollup config to add javascript license for third_party internal library #6759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

dwyfrequency
Copy link
Contributor

@dwyfrequency dwyfrequency commented Nov 7, 2022

Used in internal reference cl/486725922

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2022

⚠️ No Changeset found

Latest commit: a3a35e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 7, 2022

Size Report 1

Affected Products

  • @firebase/analytics

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?20.2 kB? (?)
    esm5?24.7 kB? (?)
    main?26.0 kB? (?)
    module?20.2 kB? (?)
  • @firebase/analytics-compat

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?2.57 kB? (?)
    esm5?2.80 kB? (?)
    main?3.24 kB? (?)
    module?2.57 kB? (?)
  • @firebase/api-documenter

    TypeBase (6efd96b)Merge (43883fd)Diff
    main?3.95 kB? (?)
  • @firebase/app

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?14.4 kB? (?)
    esm5?18.7 kB? (?)
    main?19.6 kB? (?)
    module?14.4 kB? (?)
  • @firebase/app-check

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?25.2 kB? (?)
    esm5?30.0 kB? (?)
    main?31.1 kB? (?)
    module?25.2 kB? (?)
  • @firebase/app-check-compat

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?2.27 kB? (?)
    esm5?2.48 kB? (?)
    main?2.94 kB? (?)
    module?2.27 kB? (?)
  • @firebase/app-compat

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?5.28 kB? (?)
    esm5?6.13 kB? (?)
    lite?4.06 kB? (?)
    main?6.73 kB? (?)
    module?5.28 kB? (?)
  • @firebase/auth

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?156 kB? (?)
    cordova?183 kB? (?)
    esm5?204 kB? (?)
    main?148 kB? (?)
    module?156 kB? (?)
    react-native?168 kB? (?)
  • @firebase/auth-compat

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?20.2 kB? (?)
    esm5?27.1 kB? (?)
    main?29.6 kB? (?)
    module?20.2 kB? (?)
  • @firebase/auth/cordova

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?183 kB? (?)
    module?183 kB? (?)
  • @firebase/auth/internal

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?167 kB? (?)
    esm5?218 kB? (?)
    main?184 kB? (?)
    module?167 kB? (?)
  • @firebase/auth/react-native

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?168 kB? (?)
    module?168 kB? (?)
  • @firebase/component

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?6.54 kB? (?)
    esm5?8.61 kB? (?)
    main?8.99 kB? (?)
    module?6.54 kB? (?)
  • @firebase/database

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?248 kB? (?)
    esm5?276 kB? (?)
    main?281 kB? (?)
    module?248 kB? (?)
  • @firebase/database-compat

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?18.0 kB? (?)
    esm5?21.1 kB? (?)
    main?21.8 kB? (?)
    module?18.0 kB? (?)
  • @firebase/database-compat/standalone

    TypeBase (6efd96b)Merge (43883fd)Diff
    main?370 kB? (?)
  • @firebase/firestore

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?266 kB? (?)
    esm5?330 kB? (?)
    main?531 kB? (?)
    module?266 kB? (?)
    react-native?266 kB? (?)
  • @firebase/firestore-compat

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?20.5 kB? (?)
    esm5?27.6 kB? (?)
    main?20.9 kB? (?)
    module?20.5 kB? (?)
    react-native?20.5 kB? (?)
  • @firebase/firestore-lite

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?82.4 kB? (?)
    esm5?98.6 kB? (?)
    main?139 kB? (?)
    module?82.4 kB? (?)
    react-native?82.6 kB? (?)
  • @firebase/functions

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?9.55 kB? (?)
    esm5?11.7 kB? (?)
    main?12.5 kB? (?)
    module?9.55 kB? (?)
  • @firebase/functions-compat

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?1.79 kB? (?)
    esm5?1.98 kB? (?)
    main?2.34 kB? (?)
    module?1.79 kB? (?)
  • @firebase/installations

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?17.8 kB? (?)
    esm5?22.9 kB? (?)
    main?23.8 kB? (?)
    module?17.8 kB? (?)
  • @firebase/installations-compat

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?945 B? (?)
    esm5?1.16 kB? (?)
    main?1.49 kB? (?)
    module?945 B? (?)
  • @firebase/logger

    TypeBase (6efd96b)Merge (43883fd)Diff
    esm5?4.65 kB? (?)
    main?5.32 kB? (?)
    module?3.25 kB? (?)
  • @firebase/messaging

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?21.4 kB? (?)
    esm5?26.8 kB? (?)
    main?27.5 kB? (?)
    module?21.4 kB? (?)
  • @firebase/messaging-compat

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?2.08 kB? (?)
    esm5?2.51 kB? (?)
    main?2.90 kB? (?)
    module?2.08 kB? (?)
  • @firebase/messaging-sw

    TypeBase (6efd96b)Merge (43883fd)Diff
    main?30.2 kB? (?)
    module?23.4 kB? (?)
  • @firebase/performance

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?29.1 kB? (?)
    esm5?30.8 kB? (?)
    main?31.3 kB? (?)
    module?29.1 kB? (?)
  • @firebase/performance-compat

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?1.10 kB? (?)
    esm5?1.38 kB? (?)
    main?1.69 kB? (?)
    module?1.10 kB? (?)
  • @firebase/remote-config

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?19.2 kB? (?)
    esm5?24.0 kB? (?)
    main?25.2 kB? (?)
    module?19.2 kB? (?)
  • @firebase/remote-config-compat

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?1.85 kB? (?)
    esm5?2.76 kB? (?)
    main?3.09 kB? (?)
    module?1.85 kB? (?)
  • @firebase/rules-unit-testing

    TypeBase (6efd96b)Merge (43883fd)Diff
    main?17.8 kB? (?)
  • @firebase/storage

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?55.6 kB? (?)
    esm5?61.9 kB? (?)
    main?58.5 kB? (?)
    module?55.6 kB? (?)
  • @firebase/storage-compat

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?5.67 kB? (?)
    esm5?8.41 kB? (?)
    main?8.82 kB? (?)
    module?5.67 kB? (?)
  • @firebase/util

    TypeBase (6efd96b)Merge (43883fd)Diff
    browser?22.7 kB? (?)
    esm5?24.1 kB? (?)
    main?29.6 kB? (?)
    module?22.7 kB? (?)
  • @firebase/webchannel-wrapper

    TypeBase (6efd96b)Merge (43883fd)Diff
    esm5?44.7 kB? (?)
    main?54.6 kB? (?)
    module?42.4 kB? (?)
  • bundle

    43 size changes

    TypeBase (6efd96b)Merge (43883fd)Diff
    analytics (logEvent)?43.0 kB? (?)
    app-check (CustomProvider)?36.2 kB? (?)
    app-check (ReCaptchaEnterpriseProvider)?38.5 kB? (?)
    app-check (ReCaptchaV3Provider)?38.4 kB? (?)
    auth (Anonymous)?67.5 kB? (?)
    auth (EmailAndPassword)?71.6 kB? (?)
    auth (GoogleFBTwitterGitHubPopup)?93.9 kB? (?)
    auth (GooglePopup)?91.2 kB? (?)
    auth (GoogleRedirect)?91.4 kB? (?)
    auth (Phone)?77.6 kB? (?)
    database (Append to a list of data)?148 kB? (?)
    database (Filtering data)?147 kB? (?)
    database (Listen for child events)?163 kB? (?)
    database (Listen for value events + Detach listeners)?163 kB? (?)
    database (Listen for value events)?163 kB? (?)
    database (Read data once)?162 kB? (?)
    database (Save data as transactions)?165 kB? (?)
    database (Sort data)?148 kB? (?)
    database (Write data)?147 kB? (?)
    firestore (Persistence)?276 kB? (?)
    firestore (Query Cursors)?213 kB? (?)
    firestore (Query)?214 kB? (?)
    firestore (Read data once)?202 kB? (?)
    firestore (Realtime updates)?205 kB? (?)
    firestore (Transaction)?186 kB? (?)
    firestore (Write data)?186 kB? (?)
    firestore-lite (Query Cursors)?71.5 kB? (?)
    firestore-lite (Query)?74.7 kB? (?)
    firestore-lite (Read data once)?59.1 kB? (?)
    firestore-lite (Transaction)?83.7 kB? (?)
    firestore-lite (Write data)?68.9 kB? (?)
    functions (call)?30.9 kB? (?)
    messaging (send + receive)?46.4 kB? (?)
    performance (trace)?50.8 kB? (?)
    remote-config (getAndFetch)?45.4 kB? (?)
    storage (getBytes)?40.1 kB? (?)
    storage (getDownloadURL)?42.1 kB? (?)
    storage (getMetadata)?41.6 kB? (?)
    storage (list + listAll)?41.0 kB? (?)
    storage (updateMetadata)?41.8 kB? (?)
    storage (uploadBytes)?46.5 kB? (?)
    storage (uploadBytesResumable)?56.5 kB? (?)
    storage (uploadString)?46.7 kB? (?)

  • firebase

    31 size changes

    TypeBase (6efd96b)Merge (43883fd)Diff
    firebase-analytics-compat.js?25.8 kB? (?)
    firebase-analytics.js?24.9 kB? (?)
    firebase-app-check-compat.js?22.7 kB? (?)
    firebase-app-check.js?21.4 kB? (?)
    firebase-app-compat.js?28.8 kB? (?)
    firebase-app.js?91.7 kB? (?)
    firebase-auth-compat.js?126 kB? (?)
    firebase-auth-cordova.js?137 kB? (?)
    firebase-auth-react-native.js?149 kB? (?)
    firebase-auth.js?117 kB? (?)
    firebase-compat.js?740 kB? (?)
    firebase-database-compat.js?166 kB? (?)
    firebase-database.js?154 kB? (?)
    firebase-firestore-compat.js?314 kB? (?)
    firebase-firestore-lite.js?89.1 kB? (?)
    firebase-firestore.js?314 kB? (?)
    firebase-functions-compat.js?8.12 kB? (?)
    firebase-functions.js?10.9 kB? (?)
    firebase-installations-compat.js?13.2 kB? (?)
    firebase-installations.js?12.5 kB? (?)
    firebase-messaging-compat.js?38.3 kB? (?)
    firebase-messaging-sw.js?26.0 kB? (?)
    firebase-messaging.js?24.9 kB? (?)
    firebase-performance-compat.js?30.7 kB? (?)
    firebase-performance-standalone-compat.es2017.js?90.0 kB? (?)
    firebase-performance-standalone-compat.js?66.5 kB? (?)
    firebase-performance.js?30.7 kB? (?)
    firebase-remote-config-compat.js?27.3 kB? (?)
    firebase-remote-config.js?26.4 kB? (?)
    firebase-storage-compat.js?39.1 kB? (?)
    firebase-storage.js?38.7 kB? (?)

  • functions

    TypeBase (6efd96b)Merge (43883fd)Diff
    main?46 B? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IhN7t3Qowu.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 7, 2022

@dwyfrequency dwyfrequency marked this pull request as ready for review November 8, 2022 16:09
@dwyfrequency dwyfrequency changed the title Reintroduce internal rollup config to add javascript license to third_party Reintroduce internal rollup config to add javascript license for third_party internal library Nov 8, 2022
@dwyfrequency dwyfrequency merged commit bec38d9 into master Nov 8, 2022
@dwyfrequency dwyfrequency deleted the jd-add-rollup-internal branch November 8, 2022 17:26
@firebase firebase locked and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants