TypeScript 4.7.4 upgrade for Firestore #6796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fc6ff77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅
|
This may fix build errors noted in b/258838497#comment5 and https://github.com/firebase/firebase-js-sdk/actions/runs/3467129157/jobs/5791692737
…xpression(), just like was done in the .ts file in c251444 (why is the js file checked in??
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
|
"Test All Packages" is succeeding on the master branch: #6807 I wonder why it's failing here: https://github.com/firebase/firebase-js-sdk/actions/runs/3485480218/jobs/5831056934 |
dconeybe
force-pushed
the
dconeybe/TypeScript474Upgrade
branch
from
7ffbe16 to
96150b6
Compare
dconeybe
requested review from
egilmorez,
dwyfrequency and
hsubox76
as code owners
Is the grpc-js pin comment out of date? Saw the latest commit bumps it to ~1.7.0 |
MarkDuckworth
approved these changes
Nov 18, 2022
Yes. Thanks for pointing that out. I've removed the description. |
hsubox76
reviewed
Nov 21, 2022
.changeset/breezy-wombats-care.md
Outdated
| @@ -0,0 +1,8 @@ | |||
| --- | |||
| '@firebase/database': minor | |||
There was a problem hiding this comment.
I had mentioned database because the upgrade of grps-js I think indirectly affected its version as well. But looking more closely, that probably isn't the case. I'll remove it.
hsubox76
approved these changes
Nov 21, 2022
dconeybe
added a commit
that referenced
this pull request
Nov 24, 2022
Merged
levino
pushed a commit
to levino/firebase-js-sdk
that referenced
this pull request
Dec 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.