Skip to content

TypeScript 4.7.4 upgrade for Firestore #6796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 21, 2022
Merged

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Nov 15, 2022

No description provided.

@dconeybe dconeybe self-assigned this Nov 15, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2022

🦋 Changeset detected

Latest commit: fc6ff77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Minor
@firebase/firestore-compat Minor
firebase Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

…xpression(), just like was done in the .ts file in c251444 (why is the js file checked in??
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 15, 2022

Size Report 1

Affected Products

  • @firebase/database

    TypeBase (a9add5e)Merge (4434b59)Diff
    browser248 kB247 kB-763 B (-0.3%)
    esm5276 kB275 kB-802 B (-0.3%)
    main281 kB281 kB-802 B (-0.3%)
    module248 kB247 kB-763 B (-0.3%)
  • @firebase/database-compat/standalone

    TypeBase (a9add5e)Merge (4434b59)Diff
    main370 kB369 kB-802 B (-0.2%)
  • @firebase/firestore

    TypeBase (a9add5e)Merge (4434b59)Diff
    browser266 kB266 kB-46 B (-0.0%)
    esm5330 kB332 kB+1.65 kB (+0.5%)
    main531 kB531 kB-14 B (-0.0%)
    module266 kB266 kB-46 B (-0.0%)
    react-native266 kB266 kB-46 B (-0.0%)
  • @firebase/firestore-compat

    TypeBase (a9add5e)Merge (4434b59)Diff
    esm527.6 kB27.6 kB+49 B (+0.2%)
  • @firebase/firestore-lite

    TypeBase (a9add5e)Merge (4434b59)Diff
    browser82.4 kB82.4 kB+10 B (+0.0%)
    esm598.6 kB99.5 kB+873 B (+0.9%)
    main139 kB139 kB+10 B (+0.0%)
    module82.4 kB82.4 kB+10 B (+0.0%)
    react-native82.6 kB82.6 kB+10 B (+0.0%)
  • bundle

    21 size changes

    TypeBase (a9add5e)Merge (4434b59)Diff
    database (Append to a list of data)148 kB148 kB+103 B (+0.1%)
    database (Filtering data)147 kB147 kB+103 B (+0.1%)
    database (Listen for child events)163 kB163 kB+551 B (+0.3%)
    database (Listen for value events + Detach listeners)163 kB163 kB+551 B (+0.3%)
    database (Listen for value events)163 kB163 kB+551 B (+0.3%)
    database (Read data once)162 kB163 kB+551 B (+0.3%)
    database (Save data as transactions)165 kB165 kB+551 B (+0.3%)
    database (Sort data)148 kB148 kB+103 B (+0.1%)
    database (Write data)147 kB147 kB+103 B (+0.1%)
    firestore (Persistence)276 kB276 kB-23 B (-0.0%)
    firestore (Query Cursors)213 kB213 kB-23 B (-0.0%)
    firestore (Query)214 kB214 kB-23 B (-0.0%)
    firestore (Read data once)202 kB202 kB-23 B (-0.0%)
    firestore (Realtime updates)205 kB205 kB-23 B (-0.0%)
    firestore (Transaction)186 kB186 kB-23 B (-0.0%)
    firestore (Write data)186 kB186 kB-23 B (-0.0%)
    firestore-lite (Query Cursors)71.5 kB71.5 kB+10 B (+0.0%)
    firestore-lite (Query)74.7 kB74.7 kB+10 B (+0.0%)
    firestore-lite (Read data once)59.1 kB59.1 kB+10 B (+0.0%)
    firestore-lite (Transaction)83.7 kB83.7 kB+10 B (+0.0%)
    firestore-lite (Write data)68.9 kB68.9 kB+10 B (+0.0%)

  • firebase

    TypeBase (a9add5e)Merge (4434b59)Diff
    firebase-compat.js740 kB740 kB-237 B (-0.0%)
    firebase-database-compat.js166 kB165 kB-217 B (-0.1%)
    firebase-database.js154 kB154 kB-236 B (-0.2%)
    firebase-firestore-compat.js314 kB314 kB-20 B (-0.0%)
    firebase-firestore-lite.js89.1 kB89.1 kB+10 B (+0.0%)
    firebase-firestore.js314 kB314 kB-46 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eTPX55LfQk.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 15, 2022

Size Analysis Report 1

Affected Products

  • @firebase/database

    • DataSnapshot

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size117 kB117 kB+103 B (+0.1%)
      size-with-ext-deps138 kB138 kB+103 B (+0.1%)
    • Database

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB115 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • OnDisconnect

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size119 kB119 kB+103 B (+0.1%)
      size-with-ext-deps141 kB141 kB+103 B (+0.1%)
    • QueryConstraint

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • TransactionResult

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • _QueryImpl

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB115 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • _QueryParams

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB115 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • _ReferenceImpl

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • _TEST_ACCESS_forceRestClient

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • _TEST_ACCESS_hijackHash

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • _repoManagerDatabaseFromApp

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • _setSDKVersion

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB115 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • _validatePathString

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • _validateWritablePath

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • child

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • connectDatabaseEmulator

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps138 kB138 kB+103 B (+0.1%)
    • enableLogging

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • endAt

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size118 kB118 kB+103 B (+0.1%)
      size-with-ext-deps139 kB139 kB+103 B (+0.1%)
    • endBefore

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size119 kB118 kB-418 B (-0.4%)
      size-with-ext-deps140 kB139 kB-419 B (-0.3%)

      Dependency

      TypeBase (a9add5e)Merge (4434b59)Diff
      variables

      149 dependencies

      APPLICATION_ID_PARAM
      APP_CHECK_TOKEN_PARAM
      BYTES_RECEIVED_HEALTHY_OVERRIDE
      BYTES_SENT_HEALTHY_OVERRIDE
      CONTROL_ERROR
      CONTROL_PONG
      CONTROL_RESET
      CONTROL_SHUTDOWN
      DELAY_BEFORE_SENDING_EXTRA_REQUESTS
      EMPTY_NODE
      END_TRANSMISSION
      EmptyChildren
      FIREBASE_DATABASE_EMULATOR_HOST_VAR
      FIREBASE_LONGPOLL_CALLBACK_ID_PARAM
      FIREBASE_LONGPOLL_CLOSE_COMMAND
      FIREBASE_LONGPOLL_COMMAND_CB_NAME
      FIREBASE_LONGPOLL_DATA_CB_NAME
      FIREBASE_LONGPOLL_DATA_PARAM
      FIREBASE_LONGPOLL_DISCONN_FRAME_REQUEST_PARAM
      FIREBASE_LONGPOLL_ID_PARAM
      FIREBASE_LONGPOLL_PW_PARAM
      FIREBASE_LONGPOLL_SEGMENTS_IN_PACKET
      FIREBASE_LONGPOLL_SEGMENT_NUM_PARAM
      FIREBASE_LONGPOLL_SERIAL_PARAM
      FIREBASE_LONGPOLL_START_PARAM
      FIRST_STATS_MAX_TIME
      FIRST_STATS_MIN_TIME
      FORGE_DOMAIN_RE
      FORGE_REF
      INTEGER_32_MAX
      INTEGER_32_MIN
      INTEGER_REGEXP_
      INTERRUPT_REASON
      INVALID_KEY_REGEX_
      INVALID_PATH_REGEX_
      INVALID_TOKEN_THRESHOLD
      KEEPALIVE_REQUEST_INTERVAL
      KEY_INDEX
      LAST_SESSION_PARAM
      LOG_2
      LONG_POLLING
      LP_CONNECT_TIMEOUT
      LUIDGenerator
      MAX_KEY_LEN
      MAX_LEAF_SIZE_
      MAX_NAME
      MAX_NODE
      MAX_NODE$1
      MAX_NODE$2
      MAX_PATH_DEPTH
      MAX_PATH_LENGTH_BYTES
      MAX_PAYLOAD_SIZE
      MAX_PUSH_CHAR
      MAX_TRANSACTION_RETRIES
      MAX_URL_DATA_SIZE
      MESSAGE_DATA
      MESSAGE_TYPE
      MIN_NAME
      MIN_PUSH_CHAR
      NO_COMPLETE_CHILD_SOURCE
      ObjectToUniqueKey
      OperationType
      PING
      PRIORITY_INDEX
      PROTOCOL_VERSION
      PUSH_CHARS
      PersistentStorage
      RECONNECT_DELAY_MULTIPLIER
      RECONNECT_DELAY_RESET_TIMEOUT
      RECONNECT_MAX_DELAY_DEFAULT
      RECONNECT_MAX_DELAY_FOR_ADMINS
      RECONNECT_MIN_DELAY
      REFERER_PARAM
      REPORT_STATS_INTERVAL
      SDK_VERSION
      SEG_HEADER_SIZE
      SERVER_HELLO
      SERVER_KILL_INTERRUPT_REASON
      SWITCH_ACK
      SessionStorage
      TRANSPORT_SESSION_PARAM
      UPGRADE_TIMEOUT
      USE_HINZE
      VALUE_INDEX
      VERSION_PARAM
      WEBSOCKET
      WEBSOCKET_KEEPALIVE_INTERVAL
      WEBSOCKET_MAX_FRAME_SIZE
      WebSocketImpl
      __EMPTY_NODE
      __childrenNodeConstructor
      _defaultIndexMap
      beingCrawled
      buildChildSet
      buildLogMessage_
      collections
      createStoragefor
      doubleToIEEE754String
      emptyChildrenSingleton
      enableLogging$1
      error
      exceptionGuard
      executeWhenDOMReady
      fallbackObject
      fatal
      firstLog_
      generateWithValues
      isChromeExtensionContentScript
      isInvalidJSONNumber
      isValidKey
      isValidPathString
      isValidPriority
      isValidRootPathString
      isWindowsStoreApp
      log
      logClient
      logWrapper
      logger
      name
      nameCompare
      nodeFromJSON$1
      parseDatabaseURL
      parseRepoInfo
      predecessor
      priorityHashText
      referenceConstructor
      referenceConstructor$1
      reporters
      repos
      requireKey
      resolveComplexDeferredValue
      resolveDeferredLeafValue
      resolveDeferredValueSnapshot
      resolveDeferredValueTree
      resolveScalarDeferredValue
      setTimeoutNonBlocking
      sha1
      splitStringBySize
      stringCompare
      tryParseInt
      useRestClient
      validateFirebaseData
      validateFirebaseDataArg
      validateKey
      validatePriorityNode
      validateUrl
      version
      warn
      warnIfPageIsSecure

      144 dependencies

      APPLICATION_ID_PARAM
      APP_CHECK_TOKEN_PARAM
      BYTES_RECEIVED_HEALTHY_OVERRIDE
      BYTES_SENT_HEALTHY_OVERRIDE
      CONTROL_ERROR
      CONTROL_PONG
      CONTROL_RESET
      CONTROL_SHUTDOWN
      DELAY_BEFORE_SENDING_EXTRA_REQUESTS
      EMPTY_NODE
      END_TRANSMISSION
      EmptyChildren
      FIREBASE_DATABASE_EMULATOR_HOST_VAR
      FIREBASE_LONGPOLL_CALLBACK_ID_PARAM
      FIREBASE_LONGPOLL_CLOSE_COMMAND
      FIREBASE_LONGPOLL_COMMAND_CB_NAME
      FIREBASE_LONGPOLL_DATA_CB_NAME
      FIREBASE_LONGPOLL_DATA_PARAM
      FIREBASE_LONGPOLL_DISCONN_FRAME_REQUEST_PARAM
      FIREBASE_LONGPOLL_ID_PARAM
      FIREBASE_LONGPOLL_PW_PARAM
      FIREBASE_LONGPOLL_SEGMENTS_IN_PACKET
      FIREBASE_LONGPOLL_SEGMENT_NUM_PARAM
      FIREBASE_LONGPOLL_SERIAL_PARAM
      FIREBASE_LONGPOLL_START_PARAM
      FIRST_STATS_MAX_TIME
      FIRST_STATS_MIN_TIME
      FORGE_DOMAIN_RE
      FORGE_REF
      INTEGER_32_MAX
      INTEGER_32_MIN
      INTEGER_REGEXP_
      INTERRUPT_REASON
      INVALID_KEY_REGEX_
      INVALID_PATH_REGEX_
      INVALID_TOKEN_THRESHOLD
      KEEPALIVE_REQUEST_INTERVAL
      KEY_INDEX
      LAST_SESSION_PARAM
      LOG_2
      LONG_POLLING
      LP_CONNECT_TIMEOUT
      LUIDGenerator
      MAX_LEAF_SIZE_
      MAX_NAME
      MAX_NODE
      MAX_NODE$1
      MAX_NODE$2
      MAX_PATH_DEPTH
      MAX_PATH_LENGTH_BYTES
      MAX_PAYLOAD_SIZE
      MAX_TRANSACTION_RETRIES
      MAX_URL_DATA_SIZE
      MESSAGE_DATA
      MESSAGE_TYPE
      MIN_NAME
      NO_COMPLETE_CHILD_SOURCE
      ObjectToUniqueKey
      OperationType
      PING
      PRIORITY_INDEX
      PROTOCOL_VERSION
      PersistentStorage
      RECONNECT_DELAY_MULTIPLIER
      RECONNECT_DELAY_RESET_TIMEOUT
      RECONNECT_MAX_DELAY_DEFAULT
      RECONNECT_MAX_DELAY_FOR_ADMINS
      RECONNECT_MIN_DELAY
      REFERER_PARAM
      REPORT_STATS_INTERVAL
      SDK_VERSION
      SEG_HEADER_SIZE
      SERVER_HELLO
      SERVER_KILL_INTERRUPT_REASON
      SWITCH_ACK
      SessionStorage
      TRANSPORT_SESSION_PARAM
      UPGRADE_TIMEOUT
      USE_HINZE
      VALUE_INDEX
      VERSION_PARAM
      WEBSOCKET
      WEBSOCKET_KEEPALIVE_INTERVAL
      WEBSOCKET_MAX_FRAME_SIZE
      WebSocketImpl
      __EMPTY_NODE
      __childrenNodeConstructor
      _defaultIndexMap
      beingCrawled
      buildChildSet
      buildLogMessage_
      collections
      createStoragefor
      doubleToIEEE754String
      emptyChildrenSingleton
      enableLogging$1
      error
      exceptionGuard
      executeWhenDOMReady
      fallbackObject
      fatal
      firstLog_
      generateWithValues
      isChromeExtensionContentScript
      isInvalidJSONNumber
      isValidKey
      isValidPathString
      isValidPriority
      isValidRootPathString
      isWindowsStoreApp
      log
      logClient
      logWrapper
      logger
      name
      nameCompare
      nodeFromJSON$1
      parseDatabaseURL
      parseRepoInfo
      priorityHashText
      referenceConstructor
      referenceConstructor$1
      reporters
      repos
      requireKey
      resolveComplexDeferredValue
      resolveDeferredLeafValue
      resolveDeferredValueSnapshot
      resolveDeferredValueTree
      resolveScalarDeferredValue
      setTimeoutNonBlocking
      sha1
      splitStringBySize
      stringCompare
      tryParseInt
      useRestClient
      validateFirebaseData
      validateFirebaseDataArg
      validateKey
      validatePriorityNode
      validateUrl
      version
      warn
      warnIfPageIsSecure

      - MAX_KEY_LEN
      - MAX_PUSH_CHAR
      - MIN_PUSH_CHAR
      - PUSH_CHARS
      - predecessor

    • equalTo

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size119 kB119 kB+103 B (+0.1%)
      size-with-ext-deps140 kB140 kB+103 B (+0.1%)
    • forceLongPolling

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • forceWebSockets

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • get

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size132 kB132 kB+551 B (+0.4%)
      size-with-ext-deps153 kB154 kB+551 B (+0.4%)
    • getDatabase

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB117 kB+103 B (+0.1%)
      size-with-ext-deps145 kB146 kB+103 B (+0.1%)
    • goOffline

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • goOnline

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • increment

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • limitToFirst

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • limitToLast

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • off

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size124 kB124 kB+103 B (+0.1%)
      size-with-ext-deps145 kB145 kB+103 B (+0.1%)
    • onChildAdded

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size132 kB133 kB+551 B (+0.4%)
      size-with-ext-deps154 kB154 kB+551 B (+0.4%)
    • onChildChanged

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size132 kB133 kB+551 B (+0.4%)
      size-with-ext-deps154 kB154 kB+551 B (+0.4%)
    • onChildMoved

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size132 kB133 kB+551 B (+0.4%)
      size-with-ext-deps154 kB154 kB+551 B (+0.4%)
    • onChildRemoved

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size132 kB133 kB+551 B (+0.4%)
      size-with-ext-deps154 kB154 kB+551 B (+0.4%)
    • onDisconnect

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size119 kB120 kB+103 B (+0.1%)
      size-with-ext-deps141 kB141 kB+103 B (+0.1%)
    • onValue

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size132 kB133 kB+551 B (+0.4%)
      size-with-ext-deps154 kB154 kB+551 B (+0.4%)
    • orderByChild

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size118 kB118 kB+103 B (+0.1%)
      size-with-ext-deps139 kB139 kB+103 B (+0.1%)
    • orderByKey

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size117 kB117 kB+103 B (+0.1%)
      size-with-ext-deps138 kB138 kB+103 B (+0.1%)
    • orderByPriority

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size117 kB117 kB+103 B (+0.1%)
      size-with-ext-deps138 kB138 kB+103 B (+0.1%)
    • orderByValue

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size117 kB117 kB+103 B (+0.1%)
      size-with-ext-deps138 kB138 kB+103 B (+0.1%)
    • push

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size118 kB118 kB+103 B (+0.1%)
      size-with-ext-deps139 kB139 kB+103 B (+0.1%)
    • query

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • ref

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • refFromURL

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps138 kB138 kB+103 B (+0.1%)
    • remove

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps138 kB138 kB+103 B (+0.1%)
    • runTransaction

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size134 kB135 kB+551 B (+0.4%)
      size-with-ext-deps156 kB156 kB+551 B (+0.4%)
    • serverTimestamp

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB116 kB+103 B (+0.1%)
      size-with-ext-deps137 kB137 kB+103 B (+0.1%)
    • set

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB+103 B (+0.1%)
      size-with-ext-deps138 kB138 kB+103 B (+0.1%)
    • setPriority

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size117 kB117 kB+103 B (+0.1%)
      size-with-ext-deps138 kB138 kB+103 B (+0.1%)
    • setWithPriority

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size117 kB117 kB+103 B (+0.1%)
      size-with-ext-deps138 kB138 kB+103 B (+0.1%)
    • startAfter

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size119 kB118 kB-430 B (-0.4%)
      size-with-ext-deps140 kB139 kB-430 B (-0.3%)

      Dependency

      TypeBase (a9add5e)Merge (4434b59)Diff
      variables

      149 dependencies

      APPLICATION_ID_PARAM
      APP_CHECK_TOKEN_PARAM
      BYTES_RECEIVED_HEALTHY_OVERRIDE
      BYTES_SENT_HEALTHY_OVERRIDE
      CONTROL_ERROR
      CONTROL_PONG
      CONTROL_RESET
      CONTROL_SHUTDOWN
      DELAY_BEFORE_SENDING_EXTRA_REQUESTS
      EMPTY_NODE
      END_TRANSMISSION
      EmptyChildren
      FIREBASE_DATABASE_EMULATOR_HOST_VAR
      FIREBASE_LONGPOLL_CALLBACK_ID_PARAM
      FIREBASE_LONGPOLL_CLOSE_COMMAND
      FIREBASE_LONGPOLL_COMMAND_CB_NAME
      FIREBASE_LONGPOLL_DATA_CB_NAME
      FIREBASE_LONGPOLL_DATA_PARAM
      FIREBASE_LONGPOLL_DISCONN_FRAME_REQUEST_PARAM
      FIREBASE_LONGPOLL_ID_PARAM
      FIREBASE_LONGPOLL_PW_PARAM
      FIREBASE_LONGPOLL_SEGMENTS_IN_PACKET
      FIREBASE_LONGPOLL_SEGMENT_NUM_PARAM
      FIREBASE_LONGPOLL_SERIAL_PARAM
      FIREBASE_LONGPOLL_START_PARAM
      FIRST_STATS_MAX_TIME
      FIRST_STATS_MIN_TIME
      FORGE_DOMAIN_RE
      FORGE_REF
      INTEGER_32_MAX
      INTEGER_32_MIN
      INTEGER_REGEXP_
      INTERRUPT_REASON
      INVALID_KEY_REGEX_
      INVALID_PATH_REGEX_
      INVALID_TOKEN_THRESHOLD
      KEEPALIVE_REQUEST_INTERVAL
      KEY_INDEX
      LAST_SESSION_PARAM
      LOG_2
      LONG_POLLING
      LP_CONNECT_TIMEOUT
      LUIDGenerator
      MAX_KEY_LEN
      MAX_LEAF_SIZE_
      MAX_NAME
      MAX_NODE
      MAX_NODE$1
      MAX_NODE$2
      MAX_PATH_DEPTH
      MAX_PATH_LENGTH_BYTES
      MAX_PAYLOAD_SIZE
      MAX_PUSH_CHAR
      MAX_TRANSACTION_RETRIES
      MAX_URL_DATA_SIZE
      MESSAGE_DATA
      MESSAGE_TYPE
      MIN_NAME
      MIN_PUSH_CHAR
      NO_COMPLETE_CHILD_SOURCE
      ObjectToUniqueKey
      OperationType
      PING
      PRIORITY_INDEX
      PROTOCOL_VERSION
      PUSH_CHARS
      PersistentStorage
      RECONNECT_DELAY_MULTIPLIER
      RECONNECT_DELAY_RESET_TIMEOUT
      RECONNECT_MAX_DELAY_DEFAULT
      RECONNECT_MAX_DELAY_FOR_ADMINS
      RECONNECT_MIN_DELAY
      REFERER_PARAM
      REPORT_STATS_INTERVAL
      SDK_VERSION
      SEG_HEADER_SIZE
      SERVER_HELLO
      SERVER_KILL_INTERRUPT_REASON
      SWITCH_ACK
      SessionStorage
      TRANSPORT_SESSION_PARAM
      UPGRADE_TIMEOUT
      USE_HINZE
      VALUE_INDEX
      VERSION_PARAM
      WEBSOCKET
      WEBSOCKET_KEEPALIVE_INTERVAL
      WEBSOCKET_MAX_FRAME_SIZE
      WebSocketImpl
      __EMPTY_NODE
      __childrenNodeConstructor
      _defaultIndexMap
      beingCrawled
      buildChildSet
      buildLogMessage_
      collections
      createStoragefor
      doubleToIEEE754String
      emptyChildrenSingleton
      enableLogging$1
      error
      exceptionGuard
      executeWhenDOMReady
      fallbackObject
      fatal
      firstLog_
      generateWithValues
      isChromeExtensionContentScript
      isInvalidJSONNumber
      isValidKey
      isValidPathString
      isValidPriority
      isValidRootPathString
      isWindowsStoreApp
      log
      logClient
      logWrapper
      logger
      name
      nameCompare
      nodeFromJSON$1
      parseDatabaseURL
      parseRepoInfo
      priorityHashText
      referenceConstructor
      referenceConstructor$1
      reporters
      repos
      requireKey
      resolveComplexDeferredValue
      resolveDeferredLeafValue
      resolveDeferredValueSnapshot
      resolveDeferredValueTree
      resolveScalarDeferredValue
      setTimeoutNonBlocking
      sha1
      splitStringBySize
      stringCompare
      successor
      tryParseInt
      useRestClient
      validateFirebaseData
      validateFirebaseDataArg
      validateKey
      validatePriorityNode
      validateUrl
      version
      warn
      warnIfPageIsSecure

      144 dependencies

      APPLICATION_ID_PARAM
      APP_CHECK_TOKEN_PARAM
      BYTES_RECEIVED_HEALTHY_OVERRIDE
      BYTES_SENT_HEALTHY_OVERRIDE
      CONTROL_ERROR
      CONTROL_PONG
      CONTROL_RESET
      CONTROL_SHUTDOWN
      DELAY_BEFORE_SENDING_EXTRA_REQUESTS
      EMPTY_NODE
      END_TRANSMISSION
      EmptyChildren
      FIREBASE_DATABASE_EMULATOR_HOST_VAR
      FIREBASE_LONGPOLL_CALLBACK_ID_PARAM
      FIREBASE_LONGPOLL_CLOSE_COMMAND
      FIREBASE_LONGPOLL_COMMAND_CB_NAME
      FIREBASE_LONGPOLL_DATA_CB_NAME
      FIREBASE_LONGPOLL_DATA_PARAM
      FIREBASE_LONGPOLL_DISCONN_FRAME_REQUEST_PARAM
      FIREBASE_LONGPOLL_ID_PARAM
      FIREBASE_LONGPOLL_PW_PARAM
      FIREBASE_LONGPOLL_SEGMENTS_IN_PACKET
      FIREBASE_LONGPOLL_SEGMENT_NUM_PARAM
      FIREBASE_LONGPOLL_SERIAL_PARAM
      FIREBASE_LONGPOLL_START_PARAM
      FIRST_STATS_MAX_TIME
      FIRST_STATS_MIN_TIME
      FORGE_DOMAIN_RE
      FORGE_REF
      INTEGER_32_MAX
      INTEGER_32_MIN
      INTEGER_REGEXP_
      INTERRUPT_REASON
      INVALID_KEY_REGEX_
      INVALID_PATH_REGEX_
      INVALID_TOKEN_THRESHOLD
      KEEPALIVE_REQUEST_INTERVAL
      KEY_INDEX
      LAST_SESSION_PARAM
      LOG_2
      LONG_POLLING
      LP_CONNECT_TIMEOUT
      LUIDGenerator
      MAX_LEAF_SIZE_
      MAX_NAME
      MAX_NODE
      MAX_NODE$1
      MAX_NODE$2
      MAX_PATH_DEPTH
      MAX_PATH_LENGTH_BYTES
      MAX_PAYLOAD_SIZE
      MAX_TRANSACTION_RETRIES
      MAX_URL_DATA_SIZE
      MESSAGE_DATA
      MESSAGE_TYPE
      MIN_NAME
      NO_COMPLETE_CHILD_SOURCE
      ObjectToUniqueKey
      OperationType
      PING
      PRIORITY_INDEX
      PROTOCOL_VERSION
      PersistentStorage
      RECONNECT_DELAY_MULTIPLIER
      RECONNECT_DELAY_RESET_TIMEOUT
      RECONNECT_MAX_DELAY_DEFAULT
      RECONNECT_MAX_DELAY_FOR_ADMINS
      RECONNECT_MIN_DELAY
      REFERER_PARAM
      REPORT_STATS_INTERVAL
      SDK_VERSION
      SEG_HEADER_SIZE
      SERVER_HELLO
      SERVER_KILL_INTERRUPT_REASON
      SWITCH_ACK
      SessionStorage
      TRANSPORT_SESSION_PARAM
      UPGRADE_TIMEOUT
      USE_HINZE
      VALUE_INDEX
      VERSION_PARAM
      WEBSOCKET
      WEBSOCKET_KEEPALIVE_INTERVAL
      WEBSOCKET_MAX_FRAME_SIZE
      WebSocketImpl
      __EMPTY_NODE
      __childrenNodeConstructor
      _defaultIndexMap
      beingCrawled
      buildChildSet
      buildLogMessage_
      collections
      createStoragefor
      doubleToIEEE754String
      emptyChildrenSingleton
      enableLogging$1
      error
      exceptionGuard
      executeWhenDOMReady
      fallbackObject
      fatal
      firstLog_
      generateWithValues
      isChromeExtensionContentScript
      isInvalidJSONNumber
      isValidKey
      isValidPathString
      isValidPriority
      isValidRootPathString
      isWindowsStoreApp
      log
      logClient
      logWrapper
      logger
      name
      nameCompare
      nodeFromJSON$1
      parseDatabaseURL
      parseRepoInfo
      priorityHashText
      referenceConstructor
      referenceConstructor$1
      reporters
      repos
      requireKey
      resolveComplexDeferredValue
      resolveDeferredLeafValue
      resolveDeferredValueSnapshot
      resolveDeferredValueTree
      resolveScalarDeferredValue
      setTimeoutNonBlocking
      sha1
      splitStringBySize
      stringCompare
      tryParseInt
      useRestClient
      validateFirebaseData
      validateFirebaseDataArg
      validateKey
      validatePriorityNode
      validateUrl
      version
      warn
      warnIfPageIsSecure

      - MAX_KEY_LEN
      - MAX_PUSH_CHAR
      - MIN_PUSH_CHAR
      - PUSH_CHARS
      - successor

    • startAt

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size118 kB118 kB+103 B (+0.1%)
      size-with-ext-deps139 kB139 kB+103 B (+0.1%)
    • update

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size118 kB118 kB+103 B (+0.1%)
      size-with-ext-deps139 kB139 kB+103 B (+0.1%)
  • @firebase/firestore

    • addDoc

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB-23 B (-0.0%)
      size-with-ext-deps176 kB176 kB-23 B (-0.0%)
    • deleteDoc

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size107 kB107 kB-23 B (-0.0%)
      size-with-ext-deps167 kB167 kB-23 B (-0.0%)
    • disableNetwork

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size95.8 kB95.8 kB-23 B (-0.0%)
      size-with-ext-deps155 kB155 kB-23 B (-0.0%)
    • enableIndexedDbPersistence

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size174 kB174 kB-23 B (-0.0%)
      size-with-ext-deps234 kB234 kB-23 B (-0.0%)
    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size207 kB207 kB-23 B (-0.0%)
      size-with-ext-deps267 kB267 kB-23 B (-0.0%)
    • enableNetwork

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size95.8 kB95.7 kB-23 B (-0.0%)
      size-with-ext-deps155 kB155 kB-23 B (-0.0%)
    • executeWrite

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size106 kB106 kB-23 B (-0.0%)
      size-with-ext-deps166 kB166 kB-23 B (-0.0%)
    • getCountFromServer

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size102 kB102 kB-23 B (-0.0%)
      size-with-ext-deps162 kB162 kB-23 B (-0.0%)
    • getDoc

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size133 kB133 kB-23 B (-0.0%)
      size-with-ext-deps192 kB192 kB-23 B (-0.0%)
    • getDocFromServer

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size133 kB133 kB-23 B (-0.0%)
      size-with-ext-deps192 kB192 kB-23 B (-0.0%)
    • getDocs

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size134 kB134 kB-23 B (-0.0%)
      size-with-ext-deps194 kB194 kB-23 B (-0.0%)
    • getDocsFromServer

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size134 kB134 kB-23 B (-0.0%)
      size-with-ext-deps194 kB194 kB-23 B (-0.0%)
    • loadBundle

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size105 kB105 kB-23 B (-0.0%)
      size-with-ext-deps164 kB164 kB-23 B (-0.0%)
    • onSnapshot

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size135 kB135 kB-23 B (-0.0%)
      size-with-ext-deps194 kB194 kB-23 B (-0.0%)
    • onSnapshotsInSync

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size125 kB124 kB-23 B (-0.0%)
      size-with-ext-deps184 kB184 kB-23 B (-0.0%)
    • runTransaction

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB-23 B (-0.0%)
      size-with-ext-deps176 kB176 kB-23 B (-0.0%)
    • setDoc

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size115 kB115 kB-23 B (-0.0%)
      size-with-ext-deps175 kB175 kB-23 B (-0.0%)
    • setIndexConfiguration

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size84.9 kB84.9 kB-23 B (-0.0%)
      size-with-ext-deps144 kB144 kB-23 B (-0.0%)
    • updateDoc

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size116 kB116 kB-23 B (-0.0%)
      size-with-ext-deps175 kB175 kB-23 B (-0.0%)
    • waitForPendingWrites

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size96.2 kB96.2 kB-23 B (-0.0%)
      size-with-ext-deps156 kB156 kB-23 B (-0.0%)
    • writeBatch

      Size

      TypeBase (a9add5e)Merge (4434b59)Diff
      size118 kB118 kB-23 B (-0.0%)
      size-with-ext-deps177 kB177 kB-23 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DE24EIuMiq.html

@dconeybe
Copy link
Contributor Author

"Test All Packages" is succeeding on the master branch: #6807

I wonder why it's failing here: https://github.com/firebase/firebase-js-sdk/actions/runs/3485480218/jobs/5831056934

@dconeybe dconeybe force-pushed the dconeybe/TypeScript474Upgrade branch from 7ffbe16 to 96150b6 Compare November 17, 2022 19:17
@dconeybe dconeybe marked this pull request as ready for review November 17, 2022 23:57
@hsubox76
Copy link
Contributor

Note that grpc-js was pinned at 1.6.12 because 1.6.0 and 1.7.3 all caused seemingly-unrelated timeout errors in the tests (e.g. 1, 2). The root cause is unknown, so I just accepted that v1.6.12 is good. I needed to upgrade grpc-js to fix some typing issues that resulted from upgrading TypeScript.

Is the grpc-js pin comment out of date? Saw the latest commit bumps it to ~1.7.0

Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for taking this one off my plate. I'm curious about the other comment about grpc version.

@dconeybe
Copy link
Contributor Author

Is the grpc-js pin comment out of date? Saw the latest commit bumps it to ~1.7.0

Yes. Thanks for pointing that out. I've removed the description.

@@ -0,0 +1,8 @@
---
'@firebase/database': minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why database?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had mentioned database because the upgrade of grps-js I think indirectly affected its version as well. But looking more closely, that probably isn't the case. I'll remove it.

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, I'll approve so as not to hold you up, just remove database from the changelog if it was an oversight or leave it be if there's a reason.

@dconeybe dconeybe merged commit ab3f16c into master Nov 21, 2022
@dconeybe dconeybe deleted the dconeybe/TypeScript474Upgrade branch November 21, 2022 19:38
dconeybe added a commit that referenced this pull request Nov 24, 2022
This reverts commit ab3f16c (#6796) because it (somehow?) caused the browser tests to fail in GitHub Actions.
@google-oss-bot google-oss-bot mentioned this pull request Dec 6, 2022
levino pushed a commit to levino/firebase-js-sdk that referenced this pull request Dec 10, 2022
@firebase firebase locked and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants