-
Notifications
You must be signed in to change notification settings - Fork 937
TypeScript 4.7.4 upgrade for Firestore #6796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: fc6ff77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅
|
This may fix build errors noted in b/258838497#comment5 and https://github.com/firebase/firebase-js-sdk/actions/runs/3467129157/jobs/5791692737
…xpression(), just like was done in the .ts file in c251444 (why is the js file checked in??
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
"Test All Packages" is succeeding on the master branch: #6807 I wonder why it's failing here: https://github.com/firebase/firebase-js-sdk/actions/runs/3485480218/jobs/5831056934 |
7ffbe16
to
96150b6
Compare
Is the grpc-js pin comment out of date? Saw the latest commit bumps it to ~1.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for taking this one off my plate. I'm curious about the other comment about grpc version.
Yes. Thanks for pointing that out. I've removed the description. |
.changeset/breezy-wombats-care.md
Outdated
@@ -0,0 +1,8 @@ | |||
--- | |||
'@firebase/database': minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why database?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had mentioned database
because the upgrade of grps-js
I think indirectly affected its version as well. But looking more closely, that probably isn't the case. I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, I'll approve so as not to hold you up, just remove database
from the changelog if it was an oversight or leave it be if there's a reason.
No description provided.