Add App Check token to Auth requests #6982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 968629d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lisajian
commented
Jan 26, 2023
lisajian
force-pushed
the
lj-fac-auth
branch
2 times, most recently
from
8881085 to
2bb8b1e
Compare
lisajian
commented
Jan 26, 2023
lisajian
requested review from
egilmorez,
avolkovi,
sam-gc and
yuchenshi
as code owners
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (229,775 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
lisajian
changed the title
sam-gc
approved these changes
Jan 27, 2023
| config | ||
| ); | ||
| _initializeAuthInstance(authInstance, deps); | ||
| _assert( |
There was a problem hiding this comment.
Why are we getting rid of the anon function here? I think we copied this from Firestore originally (not exactly sure why it's done this way)
There was a problem hiding this comment.
Yeahh, I wasn't sure why we had the anon function either and didn't notice a difference in behavior with / without it? I think Firestore currently doesn't use an anon function:
Will leave this open if other folks have an opinion about it
There was a problem hiding this comment.
+1 to remove the anon function if we did not observe any behavior change
|
I also added @prameshj to give her a chance to double check things |
prameshj
reviewed
Jan 28, 2023
rosalyntan
approved these changes
Jan 31, 2023
prameshj
approved these changes
Jan 31, 2023
prameshj
approved these changes
Jan 31, 2023
lisajian
added a commit
that referenced
this pull request
Feb 1, 2023
* Add App Check token to headers of Auth requests * Add App Check token to widget url fragment
lisajian
added a commit
that referenced
this pull request
Mar 1, 2023
* Add App Check token to headers of Auth requests * Add App Check token to widget url fragment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Includes App Check token in Auth header requests to backend, if present. Passes App Check token to widget via the URL fragment
As part of go/auth-app-check-sdk
Internal bug link: b/265453815
Testing
yarn testpasses inpackages/authandpackages/auth-compatAPI Changes
N/A