-
Notifications
You must be signed in to change notification settings - Fork 938
Add implementation of getGoogleAnalyticsClientId #7158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
7071d2b
Add initial implementation of getGoogleAnalyticsClientId
dwyfrequency 156137e
Update docs devsite
dwyfrequency 510a89a
Add checkset
dwyfrequency 41ef1bf
Update changeset description
dwyfrequency 8f6ac07
Add link to client_id in docstring
dwyfrequency 3e401cb
Update gtagWrapper to take variable number of args for potential fall…
dwyfrequency 4c93e53
Add API test for getGoogleAnalyticsClientId
dwyfrequency c4b9792
Move API functionality to internal function
dwyfrequency 54d83aa
Update docs for devsite
dwyfrequency 2ecd32d
Removed unused function in test
dwyfrequency 9f5cfb5
Update public api with async keyword
dwyfrequency c6d4109
Remove comment
dwyfrequency 5516b49
Update doc string
dwyfrequency 6eef67c
Update grammar of changeset
dwyfrequency eca9407
Remove console.log
dwyfrequency 0e3b900
Update variable name from targetId to measurementId
dwyfrequency 0ec1f27
Removed check for blank measurementId
dwyfrequency a585a16
Add ERROR_FACTORY for promise rejection
dwyfrequency 953e499
Change fieldName from clientId
dwyfrequency 7149472
Update AnalyticsError.NO_CLIENT_ID message
dwyfrequency 93ed844
Merge branch 'master' into jd-getclientid-analytics-v2
dwyfrequency 8332162
Testing adding comment
dwyfrequency 888aba4
remove test comment
dwyfrequency 9357f51
Remove comments
dwyfrequency File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@firebase/analytics': minor | ||
'firebase': minor | ||
--- | ||
|
||
Add method `getGoogleAnalyticsClientId()` to retrieve an unique identifier for a web client. This allows users to log purchase and other events from their backends using Google Analytics 4 Measurement Protocol and to have those events be connected to actions taken on the client within their Firebase web app. `getGoogleAnalyticsClientId()` will simplify this event recording process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.