Skip to content

Update Node version to 16 in workflows #7291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2023
Merged

Update Node version to 16 in workflows #7291

merged 2 commits into from
May 11, 2023

Conversation

hsubox76
Copy link
Contributor

E2E tests are failing because they use firebase-tools which has been recently updated. The latest version requires Node 16.13.0 or greater. We should probably update it across all workflows. We should not update it to 18 because our unit tests do not work in Node 18 due to needing to upgrade webpack.

@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ab85d06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review May 11, 2023 20:55
@hsubox76 hsubox76 requested review from dwyfrequency and a team as code owners May 11, 2023 20:55
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 11, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (7bde55c) and merge commit (1768481).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/COaJV7CwWQ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 11, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (7bde55c) and merge commit (1768481).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hqGho40jQ7.html

dwyfrequency
dwyfrequency approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 6d332b4 into master May 11, 2023
@hsubox76 hsubox76 deleted the ch-node-update branch May 11, 2023 22:37
@firebase firebase locked and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @dwyfrequency