Skip to content

Began reporting client sdk information #8271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 4, 2024
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/canary-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ jobs:
NPM_TOKEN_TESTING: ${{secrets.NPM_TOKEN_TESTING}}
NPM_TOKEN_UTIL: ${{secrets.NPM_TOKEN_UTIL}}
NPM_TOKEN_VERTEXAI: ${{secrets.NPM_TOKEN_VERTEXAI}}
NPM_TOKEN_VERTEXAI_PREVIEW: ${{secrets.NPM_TOKEN_VERTEXAI_PREVIEW}}
NPM_TOKEN_WEBCHANNEL_WRAPPER: ${{secrets.NPM_TOKEN_WEBCHANNEL_WRAPPER}}
NPM_TOKEN_FIREBASE: ${{secrets.NPM_TOKEN_FIREBASE}}
NPM_TOKEN_APP_COMPAT: ${{ secrets.NPM_TOKEN_APP_COMPAT }}
Expand Down
32 changes: 32 additions & 0 deletions .github/workflows/release-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,3 +125,35 @@ jobs:
curl -X POST -H "Content-Type:application/json" \
-d "{\"version\":\"$BASE_VERSION\",\"date\":\"$DATE\"}" \
$RELEASE_TRACKER_URL/logProduction
- name: Create Github release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
# Get the newest release tag for the firebase package (e.g. [email protected])
NEWEST_TAG=$(git describe --tags --match "firebase@[0-9]*.[0-9]*.[0-9]*" --abbrev=0)

# Get the release notes from the description of the most recent merged PR into the "release" branch
# See: https://github.com/firebase/firebase-js-sdk/pull/8236 for an example description
JSON_RELEASE_NOTES=$(gh pr list \
--repo "$GITHUB_REPOSITORY" \
--state "merged" \
--base "release" \
--limit 1 \
--json "body" \
| jq '.[].body | split("\n# Releases\n")[-1]' # Remove the generated changesets header
)

# Prepend the new release header
# We have to be careful to insert the new release header after a " character, since we're
# modifying the JSON string
JSON_RELEASE_NOTES="\"For more detailed release notes, see [Firebase JavaScript SDK Release Notes](https://firebase.google.com/support/release-notes/js).\n\n# What's Changed\n\n${JSON_RELEASE_NOTES:1}"

# Format the JSON string into a readable markdown string
RELEASE_NOTES=$(echo -E $JSON_RELEASE_NOTES | jq -r .)

# Create the GitHub release
gh release create "$NEWEST_TAG" \
--repo "$GITHUB_REPOSITORY" \
--title "$NEWEST_TAG" \
--notes "$RELEASE_NOTES" \
--verify-tag
4 changes: 1 addition & 3 deletions .github/workflows/test-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@

name: Test All Packages

on:
push:
branches: ['**']
on: pull_request

env:
# make chromedriver detect installed Chrome version and download the corresponding driver
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-changed-auth.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

name: Test Auth

on: [push, pull_request]
on: pull_request

env:
# make chromedriver detect installed Chrome version and download the corresponding driver
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ tsdoc-metadata.json
# generated html docs
docs-rut/
docs/
toc/

# generated Terraform docs
.terraform/*
Expand Down
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@ To get started using Firebase, see
[![Release Notes](https://img.shields.io/npm/v/firebase.svg?style=flat-square&label=Release%20Notes%20for&labelColor=039be5&color=666)](https://firebase.google.com/support/release-notes/js)

## Upgrade to Version 9

Version 9 has a redesigned API that supports tree-shaking. Read the [Upgrade Guide](https://firebase.google.com/docs/web/modular-upgrade) to learn more.

## Supported Environments

Please see [Environment Support](https://firebase.google.com/support/guides/environments_js-sdk).

## SDK Dev Workflow
Expand All @@ -30,7 +33,7 @@ Please see [Environment Support](https://firebase.google.com/support/guides/envi

Before you can start working on the Firebase JS SDK, you need to have Node.js
installed on your machine. As of April 19th, 2024 the team has been testing with Node.js version
`20.12.2`, but the required verison of Node.js may change as we update our dependencies.
`20.12.2`, but the required version of Node.js may change as we update our dependencies.

To download Node.js visit https://nodejs.org/en/download/.

Expand All @@ -44,7 +47,7 @@ In addition to Node.js we use `yarn` to facilitate multi package development.
To install `yarn` follow the instructions listed on their website:
https://yarnpkg.com/en/docs/install

This repo currently supports building with yarn `1.x`. For instance, after installating yarn, run
This repo currently supports building with yarn `1.x`. For instance, after installing yarn, run
```bash
$ yarn set version 1.22.11
```
Expand Down Expand Up @@ -204,7 +207,7 @@ In order to manually test your SDK changes locally, you must use [yarn link](htt
```shell
$ cd packages/firebase
$ yarn link # initialize the linking to the other folder
$ cd ../packages/<my-product> # Example: $ cd packages/database
$ cd ../<my-product> # Example: $ cd ../firestore
$ yarn link # link your product to make it available elsewhere
$ cd <my-test-app-dir> # cd into your personal project directory
$ yarn link firebase @firebase/<my-product> # tell yarn to use the locally built firebase SDK instead
Expand Down
4 changes: 2 additions & 2 deletions e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
"firebase": "9.23.0"
},
"devDependencies": {
"@babel/core": "7.24.3",
"@babel/preset-env": "7.22.10",
"@babel/core": "7.24.4",
"@babel/preset-env": "7.24.4",
"@types/chai": "4.3.14",
"@types/mocha": "9.1.1",
"babel-loader": "8.3.0",
Expand Down
12 changes: 6 additions & 6 deletions integration/compat-interop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
"test:debug": "karma start --browsers Chrome --auto-watch"
},
"dependencies": {
"@firebase/app": "0.10.3",
"@firebase/app-compat": "0.2.33",
"@firebase/analytics": "0.10.3",
"@firebase/analytics-compat": "0.2.9",
"@firebase/auth": "1.7.3",
"@firebase/auth-compat": "0.5.8",
"@firebase/app": "0.10.5",
"@firebase/app-compat": "0.2.35",
"@firebase/analytics": "0.10.4",
"@firebase/analytics-compat": "0.2.10",
"@firebase/auth": "1.7.4",
"@firebase/auth-compat": "0.5.9",
"@firebase/functions": "0.11.5",
"@firebase/functions-compat": "0.3.11",
"@firebase/messaging": "0.12.9",
Expand Down
2 changes: 1 addition & 1 deletion integration/firebase/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test"
},
"devDependencies": {
"firebase": "10.12.0",
"firebase": "10.12.2",
"@types/chai": "4.3.14",
"@types/mocha": "9.1.1",
"chai": "4.4.1",
Expand Down
4 changes: 2 additions & 2 deletions integration/firestore/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"test:memory:debug": "yarn build:memory; karma start --auto-watch --browsers Chrome"
},
"dependencies": {
"@firebase/app": "0.10.3",
"@firebase/firestore": "4.6.2"
"@firebase/app": "0.10.5",
"@firebase/firestore": "4.6.3"
},
"devDependencies": {
"@types/mocha": "9.1.1",
Expand Down
2 changes: 1 addition & 1 deletion integration/messaging/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"test:manual": "mocha --exit"
},
"devDependencies": {
"firebase": "10.12.0",
"firebase": "10.12.2",
"chai": "4.4.1",
"chromedriver": "119.0.1",
"express": "4.19.2",
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@
"repo-scripts/*"
],
"devDependencies": {
"@babel/core": "7.24.3",
"@babel/plugin-transform-modules-commonjs": "7.22.11",
"@babel/preset-env": "7.22.10",
"@babel/preset-typescript": "7.22.11",
"@babel/core": "7.24.4",
"@babel/plugin-transform-modules-commonjs": "7.24.1",
"@babel/preset-env": "7.24.4",
"@babel/preset-typescript": "7.24.1",
"@babel/register": "7.23.7",
"@changesets/changelog-github": "0.4.8",
"@changesets/cli": "2.26.2",
Expand Down
7 changes: 7 additions & 0 deletions packages/analytics-compat/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @firebase/analytics-compat

## 0.2.10

### Patch Changes

- Updated dependencies [[`f66769cca`](https://github.com/firebase/firebase-js-sdk/commit/f66769cca243019354f88ac9dc8de07caf9de56e)]:
- @firebase/[email protected]

## 0.2.9

### Patch Changes
Expand Down
6 changes: 3 additions & 3 deletions packages/analytics-compat/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@firebase/analytics-compat",
"version": "0.2.9",
"version": "0.2.10",
"description": "",
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
"main": "dist/index.cjs.js",
Expand All @@ -24,7 +24,7 @@
"@firebase/app-compat": "0.x"
},
"devDependencies": {
"@firebase/app-compat": "0.2.33",
"@firebase/app-compat": "0.2.35",
"rollup": "2.79.1",
"@rollup/plugin-json": "4.1.0",
"rollup-plugin-typescript2": "0.31.2",
Expand Down Expand Up @@ -54,7 +54,7 @@
"typings": "dist/src/index.d.ts",
"dependencies": {
"@firebase/component": "0.6.7",
"@firebase/analytics": "0.10.3",
"@firebase/analytics": "0.10.4",
"@firebase/analytics-types": "0.8.2",
"@firebase/util": "1.9.6",
"tslib": "^2.1.0"
Expand Down
6 changes: 6 additions & 0 deletions packages/analytics/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# @firebase/analytics

## 0.10.4

### Patch Changes

- [`f66769cca`](https://github.com/firebase/firebase-js-sdk/commit/f66769cca243019354f88ac9dc8de07caf9de56e) [#8243](https://github.com/firebase/firebase-js-sdk/pull/8243) (fixes [#8210](https://github.com/firebase/firebase-js-sdk/issues/8210)) - Analytics - fixed an issue where setConsent was clobbering the consentSettings before passing them to the gtag implementation.

## 0.10.3

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions packages/analytics/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@firebase/analytics",
"version": "0.10.3",
"version": "0.10.4",
"description": "A analytics package for new firebase packages",
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
"main": "dist/index.cjs.js",
Expand Down Expand Up @@ -48,7 +48,7 @@
},
"license": "Apache-2.0",
"devDependencies": {
"@firebase/app": "0.10.3",
"@firebase/app": "0.10.5",
"rollup": "2.79.1",
"@rollup/plugin-commonjs": "21.1.0",
"@rollup/plugin-json": "4.1.0",
Expand Down
Loading
Loading