Skip to content

fix: properly warn users not to use "=" character in pre or post deploy commands #6503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2023
Merged

fix: properly warn users not to use "=" character in pre or post deploy commands #6503

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4475f13
fix: properly warn users not to use "=" character in pre or post depl…
russellwheatley Nov 9, 2023
5aead2e
Merge branch 'master' into functions-5339
russellwheatley Nov 17, 2023
e2299ee
Merge branch 'master' into functions-5339
joehan Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/deploy/lifecycleHooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@ function runCommand(command: string, childOptions: childProcess.SpawnOptions) {

return new Promise<void>((resolve, reject) => {
logger.info("Running command: " + command);
if (command.includes("=")) {
utils.logWarning(
clc.yellow(clc.bold("Warning: ")) +
"Your command contains '=', it may result in the command not running." +
" Please consider removing it."
);
}
if (translatedCommand === "") {
return resolve();
}
Expand Down