Skip to content

Update find mono scripts #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Update find mono scripts #11

merged 2 commits into from
Jun 9, 2021

Conversation

cynthiajoan
Copy link
Contributor

No description provided.

@cynthiajoan cynthiajoan requested review from vimanyu and a-maurice June 6, 2021 21:23
@google-cla google-cla bot added the cla: yes label Jun 6, 2021
Copy link
Contributor

@vimanyu vimanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except a minor note on more descriptive error message.

@@ -35,7 +35,7 @@ IF EXIST ..\firebase-cpp-sdk (
IF EXIST "C:\Program Files (x86)\Mono\bin" (
SET MONO_DIR="C:/Program Files (x86)/Mono/bin"
) ELSE (
ECHO ERROR: Cant find mono
ECHO ERROR: Cant find mono in programs files x86
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are being more specific with the error here, as a user, it will be awesome to see something like this,
"Can't find mono in C:\Program Files (x86)".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried somehow the .bat file doesn't like it....

) ELSE (
ECHO ERROR: Cant find mono
ECHO ERROR: Cant find mono in program files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@cynthiajoan cynthiajoan merged commit 80c6e58 into main Jun 9, 2021
@cynthiajoan cynthiajoan deleted the origin/feature/monoupdate branch December 8, 2021 18:38
@firebase firebase locked and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants