-
Notifications
You must be signed in to change notification settings - Fork 46
Update find mono scripts #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except a minor note on more descriptive error message.
@@ -35,7 +35,7 @@ IF EXIST ..\firebase-cpp-sdk ( | |||
IF EXIST "C:\Program Files (x86)\Mono\bin" ( | |||
SET MONO_DIR="C:/Program Files (x86)/Mono/bin" | |||
) ELSE ( | |||
ECHO ERROR: Cant find mono | |||
ECHO ERROR: Cant find mono in programs files x86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are being more specific with the error here, as a user, it will be awesome to see something like this,
"Can't find mono in C:\Program Files (x86)".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried somehow the .bat file doesn't like it....
) ELSE ( | ||
ECHO ERROR: Cant find mono | ||
ECHO ERROR: Cant find mono in program files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
No description provided.