Fix the package logic, and add windows build python logic #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 28, 2022 11:05
cynthiajoan
changed the title
a-maurice
reviewed
Apr 29, 2022
.github/workflows/package.yml
Outdated
| description: 'run id for sdk_build.yml' | ||
| required: false | ||
| release_label: | ||
| description: 'If the package is intened to run for a release, put <version>-RC## for label' |
| @@ -21,7 +21,8 @@ gcs_key_file.json | |||
| *_build/ | |||
| *_unity/ | |||
| *_unity_seperate/ | |||
| *_unity_separate/ | |||
| output/ | |||
There was a problem hiding this comment.
The other separate was intentional (different spellings, with the a one being the correct one)
There was a problem hiding this comment.
done, was confused a lot, now totally make sense...
a-maurice
approved these changes
Apr 29, 2022
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @cynthiajoan on commit fd39689
|
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Type of Change
Place an
xthe applicable box: