Skip to content

Force on the CXX11_ABI flag #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Force on the CXX11_ABI flag #262

merged 1 commit into from
Apr 29, 2022

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

The Linux Unity editor was crashing in the Firestore testapp. From what I can tell, the Unity editor was likely build with this option enabled, and mixing the library without it was the cause of the crash. So we will force the option to always be on for Linux builds. Note that standalone builds were not crashing, so it was likely just a problem with the Unity editor being built with that option.


Testing

Describe how you've tested these changes.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from cynthiajoan April 29, 2022 01:18
@a-maurice
Copy link
Collaborator Author

@dconeybe
Copy link
Contributor

Details about the _GLIBCXX_USE_CXX11_ABI preprocessor define are here: https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_dual_abi.html

@a-maurice a-maurice merged commit 91f0096 into main Apr 29, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Apr 29, 2022
@github-actions
Copy link

github-actions bot commented Apr 29, 2022

❌  Integration test FAILED

Requested by @a-maurice on commit 91f0096
Last updated: Fri Apr 29 13:28 PDT 2022
View integration test log & download artifacts

Failures Configs
analytics [TEST] [FLAKINESS] [2019] [macos] [1/5 Platform(s): iOS] [1/2 Test Device(s): ios_target]
firestore [TEST] [FAILURE] [2019] [macos] [1/5 Platform(s): Android] [1/2 Test Device(s): android_target]
messaging [TEST] [ERROR] [2019] [macos] [2/5 Platform(s): Android iOS] [All 2 Test Device(s)]
storage [BUILD] [ERROR] [2019] [macos] [All 3 Platform(s)]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 29, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 29, 2022
@firebase firebase locked and limited conversation to collaborators Jun 2, 2022
@a-maurice a-maurice deleted the am-linux_editor branch June 7, 2022 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants