Skip to content

Feature/fix ios builds #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Feature/fix ios builds #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56d5c62
remove parallel build with make.
vimanyu Apr 14, 2021
eb1a5a1
remove Fabric and use FirebaseCrashlytics
vimanyu Apr 14, 2021
d635323
comment with removing parallel make
vimanyu Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build_ios.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,11 @@ pushd "$DIR"
check_exit_code $?

# Build the SDK
make -j 8
# using make -j <nprocs> is having some issues where the build hangs
# and continues on pressing return only to stop sometime later.
# Disabling parallel builds for now.
# TODO: Enable parallel builds after finding the reason
make
check_exit_code $?

# Package build output into zip
Expand Down
4 changes: 1 addition & 3 deletions crashlytics/src/cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ set(firebase_crashlytics_cpp_ios
ios/CrashlyticsiOSWrapper.m
ios/CrashlyticsiOSWrapper.h
ios/Crashlytics_PrivateHeaders/Crashlytics_Platform.h
ios/Crashlytics_PrivateHeaders/Fabric_Private.h
)

set(firebase_crashlytics_cpp_android
Expand Down Expand Up @@ -78,8 +77,7 @@ if(IOS)
setup_pod_headers(
firebase_crashlytics
POD_NAMES
Crashlytics
Fabric
FirebaseCrashlytics
)

# Crashlytics pods use 'iOS' dir instead of 'Frameworks' dir
Expand Down