Skip to content

Fix messaging duplicate symbol bug #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2022
Merged

Fix messaging duplicate symbol bug #301

merged 1 commit into from
May 19, 2022

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

In the transition to GHA, Messaging lost the extra dependency on iid it needs, or else there is a problem when also using Functions with duplicated symbols.

Testing

Describe how you've tested these changes.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

firebase/quickstart-unity#1274

@a-maurice a-maurice requested a review from cynthiajoan May 19, 2022 17:23
@a-maurice a-maurice merged commit 2dda243 into main May 19, 2022
@a-maurice a-maurice deleted the am-messaging_fix branch May 19, 2022 17:30
@firebase firebase locked and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @cynthiajoan