Skip to content

Move the testapp GameLoops logic to an androidlib #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Conversation

a-maurice
Copy link
Collaborator

Description

Unity is supposed to merge AndroidManifest files, but starting in 2020 it only checked in androidlib folders. We had incorrectly moved the AndroidManifest for GameLoops up to Plugins/Android, but that prevents it from merging in other files, like the Messaging logic. So move the GameLoops back into a subfolder, but named correctly to work with newer versions of Unity.


Testing

Messaging with 2019: https://github.com/firebase/firebase-unity-sdk/actions/runs/2633267403
Messaging with 2020: https://github.com/firebase/firebase-unity-sdk/actions/runs/2633268832
All with 2019: https://github.com/firebase/firebase-unity-sdk/actions/runs/2637673488
(The Firestore issue is an ongoing unrelated problem)


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested review from cynthiajoan and sunmou99 July 8, 2022 21:08
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jul 8, 2022
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-maurice a-maurice merged commit 2b0ee02 into main Jul 8, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 8, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit 230b8a6
Last updated: Fri Jul 8 21:00 PDT 2022
View integration test log & download artifacts

Failures Configs
analytics [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
firestore [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): Android]
functions [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
installations [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
messaging [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): ios_target]
[TEST] [FAILURE] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
storage [TEST] [FAILURE] [2019] [macos] [3/5 Platform(s): windows iOS ubuntu] [1/3 Test Device(s): simulator_target]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 9, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 9, 2022
@a-maurice a-maurice deleted the am-gameloops branch July 25, 2022 23:35
@firebase firebase locked and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants