Move the testapp GameLoops logic to an androidlib #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unity is supposed to merge AndroidManifest files, but starting in 2020 it only checked in androidlib folders. We had incorrectly moved the AndroidManifest for GameLoops up to Plugins/Android, but that prevents it from merging in other files, like the Messaging logic. So move the GameLoops back into a subfolder, but named correctly to work with newer versions of Unity.
Testing
Messaging with 2019: https://github.com/firebase/firebase-unity-sdk/actions/runs/2633267403
Messaging with 2020: https://github.com/firebase/firebase-unity-sdk/actions/runs/2633268832
All with 2019: https://github.com/firebase/firebase-unity-sdk/actions/runs/2637673488
(The Firestore issue is an ongoing unrelated problem)
Type of Change
Place an
x
the applicable box: