Skip to content

Add Tools & Scripts that build testapps #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analytics/testapp/ProjectSettings/ProjectSettings.asset
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ PlayerSettings:
buildNumber:
iOS: 0
AndroidBundleVersionCode: 1
AndroidMinSdkVersion: 16
AndroidMinSdkVersion: 26
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this being updated. We should figure out what the issue here is, because 16 should be fine, and bumping this up just hides the problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the version for now to unblock the build process.
Shawn created a ticket for this problem, and VJ is working on it. Will revert the change once it problem solved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sure we don't forget to revert it back, do you want to add a TODO in the code and link to the ticket?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a ticket. And talked with Shawn and VJ today, we are working on it now.

AndroidTargetSdkVersion: 0
AndroidPreferredInstallLocation: 1
aotOptions:
Expand Down
2 changes: 1 addition & 1 deletion auth/testapp/ProjectSettings/ProjectSettings.asset
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ PlayerSettings:
buildNumber:
iOS: 0
AndroidBundleVersionCode: 1
AndroidMinSdkVersion: 16
AndroidMinSdkVersion: 26
AndroidTargetSdkVersion: 0
AndroidPreferredInstallLocation: 1
aotOptions:
Expand Down
2 changes: 1 addition & 1 deletion crashlytics/testapp/ProjectSettings/ProjectSettings.asset
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ PlayerSettings:
buildNumber:
iOS: 0
AndroidBundleVersionCode: 1
AndroidMinSdkVersion: 16
AndroidMinSdkVersion: 26
AndroidTargetSdkVersion: 0
AndroidPreferredInstallLocation: 1
aotOptions:
Expand Down
2 changes: 1 addition & 1 deletion database/testapp/ProjectSettings/ProjectSettings.asset
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ PlayerSettings:
buildNumber:
iOS: 0
AndroidBundleVersionCode: 1
AndroidMinSdkVersion: 16
AndroidMinSdkVersion: 26
AndroidTargetSdkVersion: 0
AndroidPreferredInstallLocation: 1
aotOptions:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ PlayerSettings:
buildNumber:
iOS: 0
AndroidBundleVersionCode: 1
AndroidMinSdkVersion: 16
AndroidMinSdkVersion: 26
AndroidTargetSdkVersion: 0
AndroidPreferredInstallLocation: 1
aotOptions:
Expand Down
4 changes: 1 addition & 3 deletions firestore/testapp/Assets/Tests/Tests.asmdef
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
"UnityEditor.TestRunner"
],
"includePlatforms": [],
"excludePlatforms": [
"CloudRendering"
],
"excludePlatforms": [],
"allowUnsafeCode": false,
"overrideReferences": true,
"precompiledReferences": [
Expand Down
2 changes: 1 addition & 1 deletion firestore/testapp/ProjectSettings/ProjectSettings.asset
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ PlayerSettings:
buildNumber:
iOS: 0
AndroidBundleVersionCode: 1
AndroidMinSdkVersion: 16
AndroidMinSdkVersion: 26
AndroidTargetSdkVersion: 0
AndroidPreferredInstallLocation: 1
aotOptions:
Expand Down
2 changes: 1 addition & 1 deletion functions/testapp/ProjectSettings/ProjectSettings.asset
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ PlayerSettings:
buildNumber:
iOS: 0
AndroidBundleVersionCode: 1
AndroidMinSdkVersion: 16
AndroidMinSdkVersion: 26
AndroidTargetSdkVersion: 0
AndroidPreferredInstallLocation: 1
aotOptions:
Expand Down
4 changes: 2 additions & 2 deletions installations/testapp/ProjectSettings/ProjectSettings.asset
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ PlayerSettings:
singlePassStereoRendering: 0
protectGraphicsMemory: 0
AndroidBundleVersionCode: 1
AndroidMinSdkVersion: 14
AndroidMinSdkVersion: 26
AndroidPreferredInstallLocation: 1
aotOptions:
apiCompatibilityLevel: 2
Expand All @@ -120,7 +120,7 @@ PlayerSettings:
serializedVersion: 2
m_Bits: 238
iPhoneSdkVersion: 988
iPhoneTargetOSVersion: 28
iOSTargetOSVersionString: 10.0
tvOSSdkVersion: 0
tvOSTargetOSVersion: 900
uIPrerenderedIcon: 0
Expand Down
4 changes: 2 additions & 2 deletions messaging/testapp/ProjectSettings/ProjectSettings.asset
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ PlayerSettings:
singlePassStereoRendering: 0
protectGraphicsMemory: 0
AndroidBundleVersionCode: 1
AndroidMinSdkVersion: 14
AndroidMinSdkVersion: 26
AndroidPreferredInstallLocation: 1
aotOptions:
apiCompatibilityLevel: 2
Expand All @@ -120,7 +120,7 @@ PlayerSettings:
serializedVersion: 2
m_Bits: 238
iPhoneSdkVersion: 988
iPhoneTargetOSVersion: 28
iOSTargetOSVersionString: 10.0
tvOSSdkVersion: 0
tvOSTargetOSVersion: 900
uIPrerenderedIcon: 0
Expand Down
4 changes: 2 additions & 2 deletions remote_config/testapp/ProjectSettings/ProjectSettings.asset
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ PlayerSettings:
singlePassStereoRendering: 0
protectGraphicsMemory: 0
AndroidBundleVersionCode: 1
AndroidMinSdkVersion: 14
AndroidMinSdkVersion: 26
AndroidPreferredInstallLocation: 1
aotOptions:
apiCompatibilityLevel: 2
Expand All @@ -120,7 +120,7 @@ PlayerSettings:
serializedVersion: 2
m_Bits: 238
iPhoneSdkVersion: 988
iPhoneTargetOSVersion: 28
iOSTargetOSVersionString: 10.0
tvOSSdkVersion: 0
tvOSTargetOSVersion: 900
uIPrerenderedIcon: 0
Expand Down
Loading