Skip to content

[Bugfix] download android ndk only once #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 27, 2022
Merged

[Bugfix] download android ndk only once #424

merged 13 commits into from
Jul 27, 2022

Conversation

sunmou99
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jul 27, 2022
@sunmou99 sunmou99 changed the title Bugfix/android ndk [Bugfix] download android ndk only once Jul 27, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 27, 2022
@github-actions
Copy link

github-actions bot commented Jul 27, 2022 •
edited
Loading

❌  Integration test FAILED (but still ⏳  in progress)

Requested by @firebase-workflow-trigger[bot] on commit f4b4bd4
Last updated: Wed Jul 27 13:08 PDT 2022
View integration test log & download artifacts

Failures Configs
missing_log [BUILD] [ERROR] [2019] [macos] [Android]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 27, 2022
@sunmou99 sunmou99 merged commit 8fba07a into main Jul 27, 2022
@sunmou99 sunmou99 deleted the bugfix/android-ndk branch July 27, 2022 21:46
@firebase firebase locked and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed. tests: in-progress This PR's integration tests are in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunmou99 @cynthiajoan @a-maurice