Uninstall Android platforms that fail with Unity #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Firestore Android testapp was failing to build, because it requires minification. The root cause is that the GitHub runners have the android-33 platform installed, and since it is the latest one, Unity tries to build with it, but some of the libraries (android.car.jar as an example) was build with Java 11. This requires a newer JDK and Gradle than Unity uses, which causes the build to fail. As a workaround, we can uninstall android-33 (the runners have 27 through 33 installed).
Testing
https://github.com/firebase/firebase-unity-sdk/actions/runs/2792702607
Type of Change
Place an
xthe applicable box: