Fix #218 that Firebase editor tool not loading when iOS build support is not installed #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crashlytics editor tool will not load if the user only adds Android build support to the Unity editor. This is because Unity has more restricted validation to function signature when loading dlls. This fix avoids passing `UnityEditor.iOS.Extensions.Xcode.PBXProject` directly but passing an `object` instead. Also fixes the integration test script just in case we want to run the test againt only one build target.
chkuang-g
force-pushed
the
patch/crashlytics-editor-tool
branch
from
e76e274 to
0a2a52f
Compare
chkuang-g
added
the
tests-requested: full
a-maurice
approved these changes
Sep 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Crashlytics editor tool will not load if the user only adds Android build support to the Unity editor but not iOS build support. This is because Unity has more restricted validation to function signature when loading dlls.
This fix avoids passing
UnityEditor.iOS.Extensions.Xcode.PBXProjectdirectly but passing anobjectinstead.Also fixes the integration test script just in case we want to run the test against only one build target.
Testing
GHA integration test
Type of Change
Place an
xthe applicable box: