Skip to content

Change how Messaging testapp gets registration token #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented Aug 30, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

The OnTokenReceived callback is only called for new Messaging Tokens, so if the App has a cached token, it would not receive a new token, and thus the tests would timeout while waiting for it. Change the tests to use GetTokenAsync if necessary to get a token, and throw exceptions if the token is still missing.


Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/6028673810


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from cynthiajoan August 30, 2023 00:10
@a-maurice a-maurice merged commit 6f801c5 into main Aug 30, 2023
@a-maurice a-maurice deleted the am-messaging_android branch August 30, 2023 19:57
@firebase firebase locked and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants