Skip to content

Change how Messaging Activity cleans up in 2023 #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2023
Merged

Change how Messaging Activity cleans up in 2023 #850

merged 1 commit into from
Sep 5, 2023

Conversation

a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented Aug 31, 2023 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

The Unity 2023.2 beta is seemingly removing mUnityActivity's quit(). Change it to use destroy(), which should have the same overall effect.

Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/6043471004

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

#842

@a-maurice a-maurice merged commit 509e63e into main Sep 5, 2023
@a-maurice a-maurice deleted the am-messaging_problems branch September 5, 2023 21:01
@firebase firebase locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @cynthiajoan