Skip to content

Add logic to retry playmode tests #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Add logic to retry playmode tests #857

merged 3 commits into from
Sep 6, 2023

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Add logic to retry playmode tests. These tests are generally a bit flakey, so add logic to retry the tests a couple of times, to account for this flakiness. Note that we do something similar in the C++ repo already.


Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/6031700442


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from sunmou99 September 5, 2023 20:07
@a-maurice a-maurice changed the title Am retry playmode Add logic to retry playmode tests Sep 5, 2023
@a-maurice a-maurice merged commit 670fc60 into main Sep 6, 2023
@a-maurice a-maurice deleted the am-retry_playmode branch September 6, 2023 06:21
@firebase firebase locked and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants