fix(*): operator == takes Object parameter (#5443)

Close #5288

Author: mockturtl

packages/cloud_firestore/cloud_firestore/lib/src/collection_reference.dart

@@ -65,7 +65,7 @@ class CollectionReference extends Query {
   }
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       other is CollectionReference &&
       other.firestore == firestore &&
       other.path == path;

packages/cloud_firestore/cloud_firestore/lib/src/document_reference.dart

@@ -88,7 +88,7 @@ class DocumentReference {
 
   @override
   // ignore: avoid_equals_and_hash_code_on_mutable_classes
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       other is DocumentReference &&
       other.firestore == firestore &&
       other.path == path;

packages/cloud_firestore/cloud_firestore/lib/src/firestore.dart

@@ -207,7 +207,7 @@ class FirebaseFirestore extends FirebasePluginPlatform {
 
   @override
   // ignore: avoid_equals_and_hash_code_on_mutable_classes
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       other is FirebaseFirestore && other.app.name == app.name;
 
   @override

packages/cloud_firestore/cloud_firestore_platform_interface/lib/src/blob.dart

@@ -19,7 +19,7 @@ class Blob {
   final Uint8List bytes;
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       other is Blob &&
       const DeepCollectionEquality().equals(other.bytes, bytes);
 

packages/cloud_firestore/cloud_firestore_platform_interface/lib/src/field_path.dart

@@ -50,7 +50,7 @@ class FieldPath {
         assert(!path.contains(']'), _reserved);
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       other is FieldPath &&
       const ListEquality().equals(other.components, components);
 

packages/cloud_firestore/cloud_firestore_platform_interface/lib/src/geo_point.dart

@@ -18,7 +18,7 @@ class GeoPoint {
   final double longitude; // ignore: public_member_api_docs
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       other is GeoPoint &&
       other.latitude == latitude &&
       other.longitude == longitude;

packages/cloud_firestore/cloud_firestore_platform_interface/lib/src/internal/pointer.dart

@@ -73,7 +73,7 @@ class Pointer {
   }
 
   @override
-  bool operator ==(dynamic other) => other is Pointer && other.path == path;
+  bool operator ==(Object other) => other is Pointer && other.path == path;
 
   @override
   int get hashCode => path.hashCode;

packages/cloud_firestore/cloud_firestore_platform_interface/lib/src/method_channel/method_channel_field_value.dart

@@ -44,7 +44,7 @@ class MethodChannelFieldValue {
   final dynamic value;
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       other is MethodChannelFieldValue &&
       other.type == type &&
       const DeepCollectionEquality().equals(other.value, value);

packages/cloud_firestore/cloud_firestore_platform_interface/lib/src/settings.dart

@@ -53,7 +53,7 @@ class Settings {
   }
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       other is Settings && other.asMap.toString() == asMap.toString();
 
   @override

packages/cloud_firestore/cloud_firestore_platform_interface/lib/src/timestamp.dart

@@ -87,7 +87,7 @@ class Timestamp implements Comparable<Timestamp> {
   int get hashCode => hashValues(seconds, nanoseconds);
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       other is Timestamp &&
       other.seconds == seconds &&
       other.nanoseconds == nanoseconds;

packages/cloud_firestore/cloud_firestore_web/lib/src/field_value_web.dart

@@ -17,7 +17,7 @@ class FieldValueWeb {
 
   @override
   //ignore: avoid_equals_and_hash_code_on_mutable_classes
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       other is FieldValueWeb && other.data == data;
 
   @override

packages/firebase_core/firebase_core/lib/src/firebase.dart

@@ -59,7 +59,7 @@ class Firebase {
   // TODO(rrousselGit): remove ==/hashCode
   @override
   // ignore: avoid_equals_and_hash_code_on_mutable_classes
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (identical(this, other)) return true;
     if (other is! Firebase) return false;
     return other.hashCode == hashCode;

packages/firebase_core/firebase_core/lib/src/firebase_app.dart

@@ -56,7 +56,7 @@ class FirebaseApp {
 
   @override
   // ignore: avoid_equals_and_hash_code_on_mutable_classes
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (identical(this, other)) return true;
     if (other is! FirebaseApp) return false;
     return other.name == name && other.options == options;

packages/firebase_core/firebase_core/test/firebase_core_test.dart

@@ -111,10 +111,4 @@ class MockFirebaseCore extends Mock
 }
 
 // ignore: avoid_implementing_value_types
-class FakeFirebaseAppPlatform extends Fake implements FirebaseAppPlatform {
-  @override
-  // ignore: avoid_equals_and_hash_code_on_mutable_classes, hash_and_equals
-  bool operator ==(Object? other) {
-    return super == other;
-  }
-}
+class FakeFirebaseAppPlatform extends Fake implements FirebaseAppPlatform {}

packages/firebase_core/firebase_core_platform_interface/lib/src/firebase_exception.dart

@@ -54,7 +54,7 @@ class FirebaseException implements Exception {
   final StackTrace? stackTrace;
 
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (identical(this, other)) return true;
     if (other is! FirebaseException) return false;
     return other.hashCode == hashCode;

packages/firebase_core/firebase_core_platform_interface/lib/src/firebase_options.dart

@@ -165,7 +165,7 @@ class FirebaseOptions {
 
   // Required from `fromMap` comparison
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (identical(this, other)) return true;
     if (other is! FirebaseOptions) return false;
     return other.asMap.toString() == asMap.toString();

packages/firebase_core/firebase_core_platform_interface/lib/src/platform_interface/platform_interface_firebase_app.dart

@@ -60,7 +60,7 @@ class FirebaseAppPlatform extends PlatformInterface {
 
   @override
   // ignore: avoid_equals_and_hash_code_on_mutable_classes
-  bool operator ==(Object? other) {
+  bool operator ==(Object other) {
     if (identical(this, other)) return true;
     if (other is! FirebaseAppPlatform) return false;
     return other.name == name && other.options == options;

packages/firebase_core/firebase_core_platform_interface/test/platform_interface_tests/platform_interface_firebase_core_test.dart

@@ -52,13 +52,7 @@ class ImplementsFirebasePlatform implements FirebasePlatform {
 }
 
 // ignore: avoid_implementing_value_types
-class FakeFirebaseAppPlatform extends Fake implements FirebaseAppPlatform {
-  @override
-  // ignore: avoid_equals_and_hash_code_on_mutable_classes, hash_and_equals, false positive
-  bool operator ==(Object? other) {
-    return super == other;
-  }
-}
+class FakeFirebaseAppPlatform extends Fake implements FirebaseAppPlatform {}
 
 class ExtendsFirebasePlatform extends FirebasePlatform {}
 

packages/firebase_storage/firebase_storage/lib/src/firebase_storage.dart

@@ -150,7 +150,7 @@ class FirebaseStorage extends FirebasePluginPlatform {
   }
 
   @override
-  bool operator ==(Object? other) =>
+  bool operator ==(Object other) =>
       other is FirebaseStorage &&
       other.app.name == app.name &&
       other.bucket == bucket;

packages/firebase_storage/firebase_storage/lib/src/reference.dart

@@ -195,7 +195,7 @@ class Reference {
   }
 
   @override
-  bool operator ==(Object? other) =>
+  bool operator ==(Object other) =>
       other is Reference &&
       other.fullPath == fullPath &&
       other.storage == storage;