🐛 [cloud_firestore] 'Object.==' and Mockito

[radvansky-tomas]

I am trying to mock flutter fire plugin using Mockito, however generation fails because of using 'Object.==' inside many flutter fire classes. I reported it to Mockito plugin, however they doubt you should be using it.

Any input from your end ?

dart-lang/mockito#354

[mockturtl]

This is also relevant to firebase_auth.

With @GenerateMocks([FirebaseAuth]), the code generation succeeds, but the analyzer finds an invalid_implementation_override error in the generated class for FirebaseApp.

# pubspec.yaml
dependencies:
  flutter:
    sdk: flutter  # 2.0.2
  firebase_auth: ^1.0.1

dev_dependencies:
  flutter_test:
    sdk: flutter
  build_runner: ^1.12.2
  mockito: ^5.0.2

$ dart run build_runner build

// my_test_mocks.dart
// Mocks generated by Mockito 5.0.2 from annotations
// in my_test.dart.
// Do not manually edit this file.
...
class _FakeFirebaseApp extends _i1.Fake implements _i2.FirebaseApp {}

error • 'Object.==' ('bool Function(Object)') isn't a valid concrete implementation of 'FirebaseApp.==' ('bool Function(dynamic)') at ... • (invalid_implementation_override)

dart-lang/mockito#354 (comment)

I suggest opening bugs against those packages, perhaps asking why they expanded the parameter type on the == operator. It may be accidental.

[gmcdowell]

this is an encouraging nudge to get this addressed ASAP please, given the use of Mockito and Firebase is fundamental and this issue is currently not viewed as a bug

[radvansky-tomas]

@markusaksli-nc Can you please explain what next ? do you have any remedy/workaround/plan to resolve it ?

[markusaksli-nc]

I'm not really the person to ask for that. It would help if you permalink some code lines where this is an issue (following the recent null-safety updates)

[mockturtl]

It would help if you permalink some code lines where this is an issue

See link, above. Object's operator == takes an Object parameter. Mockito's question is why flutterfire changes the type to dynamic in its @overrides.

PR incoming.

[gmcdowell]

@markusaksli-nc given @mockturtl has done as you ask can you provide us with an eta at all?
This is a blocker from out POV and would really appreciate some escalation

Ah I can see movement in the issue, so will park this for time being ;)