Skip to content

[📚] Migrating FlutterFire initialization misleading docs #7866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edhom opened this issue Jan 14, 2022 · 9 comments · Fixed by #8167
Closed

[📚] Migrating FlutterFire initialization misleading docs #7866

edhom opened this issue Jan 14, 2022 · 9 comments · Fixed by #8167
Labels
good first issue Good for newcomers resolution: fixed A fix has been merged or is pending merge from a PR. type: documentation Improvements or additions to documentation

Comments

@edhom
Copy link

edhom commented Jan 14, 2022

This tip is really misleading. You cannot safely remove the configuration files as long as there are services not supporting dart initialization.
Screen Shot 2022-01-14 at 09 48 08

@edhom edhom added good first issue Good for newcomers type: documentation Improvements or additions to documentation labels Jan 14, 2022
@darshankawar darshankawar added the triage Issue is currently being triaged. label Jan 14, 2022
@darshankawar
Copy link

as long as there are services not supporting dart initialization.

See if this link helps to answer which services are supported and which are not : https://firebase.flutter.dev/docs/cli/#usage

@darshankawar darshankawar added the blocked: customer-response Waiting for customer response, e.g. more information was requested. label Jan 14, 2022
@pree-T
Copy link

pree-T commented Jan 16, 2022

May I work on it? Can someone help me as I am new to open source contribution?

@edhom
Copy link
Author

edhom commented Jan 17, 2022

@darshankawar Thanks for the link👍 So in case you'd like to migrate, but use one or more of these unsupported services, can you use the old configuration files to initialize those and dart initialization for everything else? Or in other words: Can you migrate partially? If so, is there anything you need to pay attention to? (E.g. adjusting the configuration files?). Would be really thankful for some advise here!

@google-oss-bot google-oss-bot added Needs Attention This issue needs maintainer attention. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Jan 17, 2022
@creativecreatorormaybenot
Copy link
Contributor

@darshankawar That would mean that the docs are wrong:

If you're using FlutterFire in an existing application, you can safely remove any manual native installation steps (such as the google-services.json or GoogleService-Info.plist files). Dart-only initialization is backwards compatible with manual-installation.

This is not in accordance with the link you shared (https://firebase.flutter.dev/docs/cli/#usage) because for Analytics, Crashlytics, Dynamic Links, and Performance Monitoring, the files are required.

@darshankawar
Copy link

Can you migrate partially? If so, is there anything you need to pay attention to? (E.g. adjusting the configuration files?). Would be really thankful for some advise here!

I haven't tried to implement partial migration yet, so not sure how it works currently. Keeping it open and labeling for team to provide input on such scenario.

/cc @russellwheatley

@darshankawar darshankawar removed Needs Attention This issue needs maintainer attention. triage Issue is currently being triaged. labels Jan 18, 2022
@neiljaywarner
Copy link

@darshankawar @russellwheatley @creativecreatorormaybenot I love flutter and firebase but this made me very sad. analytics and crashlytics are the two most key features. I'm also using remote config.
The big green box saying "no longer recommended" and i think reference to having changed this in mid 2020. Not working with android on crashlytics (there's a non-clickable question mark and it doens't work for me, gives analytics disabled, no google app id but works on ios).
basically the whole idea seems practically broken, it seemed like such a great idea too, especially when using flavors...

Can you please escalate? @puf or anybody . if you can't use analytics on android then it can't be teh "main" recommended way.
E/FA (27683): Missing google_app_id. Firebase Analytics disabled. See https://goo.gl/NAOOOI

@neiljaywarner
Copy link

@russellwheatley @darshankawar this is good but what about an eta on the real problem? Getting this working would make flavors much less painful i think :)

@russellwheatley
Copy link
Member

@neiljaywarner - we're working on it. Some of the work required is out of our hands I'm afraid so we cannot give you a timeframe, but we'll update the documentation as and when the landscape changes.

@neiljaywarner
Copy link

neiljaywarner commented Feb 24, 2022 via email

@darshankawar darshankawar added the resolution: fixed A fix has been merged or is pending merge from a PR. label Feb 28, 2022
@firebase firebase locked and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers resolution: fixed A fix has been merged or is pending merge from a PR. type: documentation Improvements or additions to documentation
Projects
None yet
8 participants
@neiljaywarner @russellwheatley @creativecreatorormaybenot @google-oss-bot @edhom @pree-T @darshankawar and others