Skip to content

refactor!: remove FallThroughError before deletion in Dart 3 #10081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Dec 9, 2022

Description

The API FallThroughError is deprecated and scheduled for dart-lang/sdk#49529.

Replacing with Exception

Related Issues

closes #10079

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone changed the title refactor: remove FallThroughError before deletion in Dart 3 refactor!: remove FallThroughError before deletion in Dart 3 Dec 9, 2022
@dcharkes
Copy link
Contributor

Drive by comment (as I seem to have made a PR for the same issue). Is the change from Error to Exception intended? I chose UnsupportedError error instead.

See: Exceptions are recoverable, errors are not.

@Lyokone
Copy link
Contributor Author

Lyokone commented Dec 12, 2022

@dcharkes Thanks we were discussing this internally, and I hadn't updated my PR yet. I'll close it in favor of yours.

@Lyokone Lyokone closed this Dec 12, 2022
@mit-mit
Copy link
Contributor

mit-mit commented Dec 12, 2022

New PR is #10087

@firebase firebase locked and limited conversation to collaborators Jan 12, 2023
@Lyokone Lyokone deleted the refactor/fallthrougherror branch October 7, 2024 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [auth][firestore][database] Remove use of deprecated FallThroughError API
3 participants