Skip to content

feat: upgrade to dart 3 compatible dependencies #10890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 4, 2023
Merged

feat: upgrade to dart 3 compatible dependencies #10890

merged 15 commits into from
May 4, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented May 2, 2023

Description

Upgraded to support Dart 3.
Some tests will produce some null safety warnings since some objects become non-nullable in Dart 3.
Latest running CI with beta is here: one skipped test cause of timeout working locally.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone requested review from Salakar and kroikie as code owners May 2, 2023 09:45
@Lyokone Lyokone changed the title ci: check if compatible with dart 3 feat: upgrade to dart 3 compatible dependencies May 2, 2023
@Lyokone Lyokone requested a review from lesnitsky as a code owner May 2, 2023 13:37
@Lyokone Lyokone merged commit 4bd7e59 into master May 4, 2023
@Lyokone Lyokone deleted the dart-3 branch May 4, 2023 11:56
@firebase firebase locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants