fix(messaging): revert change to getParcelableExtra() that may result in crash
#11163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
reviewed
Jun 21, 2023
| @@ -5,7 +5,7 @@ buildscript { | |||
| } | |||
|
|
|||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:8.0.1' | |||
| classpath 'com.android.tools.build:gradle:7.4.1' | |||
There was a problem hiding this comment.
I think we can keep gradle 8.0.1, it shouldn't cause issues
There was a problem hiding this comment.
I'm afraid it does cause issues, it requires Java 17
There was a problem hiding this comment.
But this is the gradle file of the example app, should not impact the release
There was a problem hiding this comment.
True, it won't impact the release, but anyone trying to build the example app won't be able to without java 17. It's an easy win.
Salakar
approved these changes
Jun 22, 2023
russellwheatley
changed the title
getParcelableExtra() that may result in crashgetParcelableExtra() that may result in crash
Lyokone
approved these changes
Jun 22, 2023
|
I get this error using firebase_messaging: ^14.6.2, on every second notification received. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very hard to debug why the crash occurs, but it happens from time to time so reverting back to previous implementation for now to resolve the issue.
Related Issues
fix: #11142
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?