Skip to content

fix(messaging): macos incorrect parsing of notification response … #17231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ - (void)messaging:(nonnull FIRMessaging *)messaging
- (void)application_onDidFinishLaunchingNotification:(nonnull NSNotification *)notification {
// Setup UIApplicationDelegate.
#if TARGET_OS_OSX
NSDictionary *remoteNotification = notification.userInfo[NSApplicationLaunchUserNotificationKey];
UNNotificationResponse *notificationResponse = notification.userInfo[NSApplicationLaunchUserNotificationKey];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, I am sorry I did not see this sooner. It looks alright to me. Can I get you to fix formatting issues that occured on CI? Should be very quick.

NSDictionary *remoteNotification = notificationResponse.notification.request.content.userInfo;
#else
NSDictionary *remoteNotification =
notification.userInfo[UIApplicationLaunchOptionsRemoteNotificationKey];
Expand Down
Loading