Skip to content

docs(firebase_analytics): example app initialization and docs support status #7745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 5, 2022

Conversation

pr-Mais
Copy link
Member

@pr-Mais pr-Mais commented Dec 31, 2021

Description

Fixed the initialization part in the example app for firebase_analytics and addd the support status section to show which plugins/platforms currently doesn't support the Dart-only initialization.

Related Issues

closes #7639
closes #7543

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@github-actions
Copy link

github-actions bot commented Dec 31, 2021

Visit the preview URL for this PR (updated for commit a34cc44):

https://flutter-firebase-docs--pr7745-analytics-example-uc6ihq0q.web.app

(expires Wed, 12 Jan 2022 13:25:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes from me. I think you'll also need to add back in the google service file for example/android as well.

pr-Mais and others added 4 commits January 4, 2022 16:03
Co-authored-by: Russell Wheatley <[email protected]>
Co-authored-by: Russell Wheatley <[email protected]>
Co-authored-by: Russell Wheatley <[email protected]>
@pr-Mais
Copy link
Member Author

pr-Mais commented Jan 4, 2022

Yeah it's there https://github.com/FirebaseExtended/flutterfire/tree/analytics-example/packages/firebase_analytics/firebase_analytics/example/android/app

@Ehesp
Copy link
Member

Ehesp commented Jan 4, 2022

Is the PR title correct here? It says fix but only applies docs and examples changes so shouldn't change versions of anything?

@pr-Mais
Copy link
Member Author

pr-Mais commented Jan 4, 2022

yes I agree, docs could be?

@pr-Mais pr-Mais changed the title fix(firebase_analytics): example app initialization and docs support status docs(firebase_analytics): example app initialization and docs support status Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants